Skip to content

test: skip recall test for 4bit PQ#5861

Merged
Xuanwo merged 1 commit intomainfrom
yang/pq4-recall-test
Jan 30, 2026
Merged

test: skip recall test for 4bit PQ#5861
Xuanwo merged 1 commit intomainfrom
yang/pq4-recall-test

Conversation

@BubbleCal
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@github-actions github-actions Bot added the chore label Jan 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Code Review

P0: Missing context and tracking issue

This PR disables recall checks for 4-bit PQ tests by setting recall_requirement to 0.0, but:

  1. No explanation for why this is needed - The PR body is empty and there's no linked issue. What's causing the recall to fail? Is it a bug in the 4-bit PQ implementation, flaky tests, or expected behavior?

  2. No tracking issue - If this is truly temporary (as the comment says), there should be a GitHub issue linked to track when these tests should be re-enabled.

  3. Tests effectively become no-ops - With recall_requirement = 0.0, these tests no longer validate recall quality at all. Consider using #[ignore] instead if the tests are temporarily broken, as this makes it clearer the tests are intentionally skipped and shows up in test output.

Suggested approach:

  • Add context in the PR description explaining what's failing and why
  • Create a tracking issue and reference it in the comment
  • Consider using #[ignore = "Tracking issue #XXX"] instead of setting recall to 0.0, which would be more explicit

Without understanding the root cause, it's hard to assess whether disabling these tests is the right approach.

Copy link
Copy Markdown
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test case is flaky and not widely used in production environments. Skipping it looks good to me.

@Xuanwo Xuanwo merged commit 93e81d5 into main Jan 30, 2026
27 checks passed
@Xuanwo Xuanwo deleted the yang/pq4-recall-test branch January 30, 2026 11:09
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

vivek-bharathan pushed a commit to vivek-bharathan/lance that referenced this pull request Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants