Skip to content

fix: properly skip fp16kernels if not enabled and allow building on ios #5866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chyyran wants to merge 1 commit into from
Closed

fix: properly skip fp16kernels if not enabled and allow building on ios #5866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions rust/lance-linalg/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,20 @@ fn main() -> Result<(), String> {
return Ok(());
}

if cfg!(not(feature = "fp16kernels")) {
println!(
"cargo:warning=fp16kernels feature is not enabled, skipping build of fp16 kernels"
);
return Ok(());
}

if target_arch == "aarch64" && target_os == "macos" {
// Build a version with NEON
build_f16_with_flags("neon", &["-mtune=apple-m1"]).unwrap();
} else if target_arch == "aarch64" && target_os == "ios" {
// Build version with NEON
// A13 bionic is the earliest supported iOS SOC
build_f16_with_flags("neon", &["-mtune=apple-a13"]).unwrap();
} else if target_arch == "aarch64" && target_os == "linux" {
// Build a version with NEON
build_f16_with_flags("neon", &["-march=armv8.2-a+fp16"]).unwrap();
Expand Down
Loading