fix: flaky test test_ann_prefilter for HNSW#5870
Merged
Conversation
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
Contributor
PR ReviewSummary: This PR adds AssessmentThe fix is reasonable. The No Major Issues FoundThis is a minimal, targeted fix that:
LGTM ✓ |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
vivek-bharathan
pushed a commit
to vivek-bharathan/lance
that referenced
this pull request
Feb 2, 2026
this test searches for top1 which could lead to greedy search for HNSW, fix it by setting `ef` Signed-off-by: BubbleCal <bubble-cal@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this test searches for top1 which could lead to greedy search for HNSW, fix it by setting
ef