Skip to content

feat: add rename table implementations to REST namespaces#5874

Merged
jackye1995 merged 8 commits intolance-format:mainfrom
bryanck:rest-rename
Feb 6, 2026
Merged

feat: add rename table implementations to REST namespaces#5874
jackye1995 merged 8 commits intolance-format:mainfrom
bryanck:rest-rename

Conversation

@bryanck
Copy link
Copy Markdown
Contributor

@bryanck bryanck commented Feb 2, 2026

This PR adds the Python and Java bindings for rename table using the REST namespace. This is already implemented in Rust.

@bryanck bryanck requested a review from jackye1995 February 2, 2026 17:12
@github-actions github-actions Bot added enhancement New feature or request python java labels Feb 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 2, 2026

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@bryanck bryanck changed the title feat: Add rename table implementations to REST namespaces feat: add rename table implementations to REST namespaces Feb 2, 2026
Copy link
Copy Markdown
Contributor

@jackye1995 jackye1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks for the work! pending CI green

@bryanck
Copy link
Copy Markdown
Contributor Author

bryanck commented Feb 4, 2026

I had to comment out the test assertions and added a TODO comment, because the REST adapter relies on the directory namespace implementation.

I considered a couple of options, one was to implement rename in the directory namespace. The second was to create a new in-memory namespace implementation and use that with the REST adapter instead. Both of those options were fairly significant changes so I felt we could follow up with that in another PR.

@jackye1995 do you have thoughts on that?

@jackye1995 jackye1995 merged commit 303f58f into lance-format:main Feb 6, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request java python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants