Skip to content

ci: fix bump version failed#5879

Merged
wjones127 merged 1 commit intolance-format:mainfrom
majin1102:fix-publish
Feb 3, 2026
Merged

ci: fix bump version failed#5879
wjones127 merged 1 commit intolance-format:mainfrom
majin1102:fix-publish

Conversation

@majin1102
Copy link
Copy Markdown
Contributor

@majin1102 majin1102 commented Feb 3, 2026

Publish beta failed because:
image

We should add this pinned version

@github-actions github-actions Bot added the bug Something isn't working label Feb 3, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 3, 2026

PR Review

Summary: This PR adds the missing lance-namespace-datafusion workspace dependency to fix the bumpversion/publish workflow failure.

Assessment: ✅ LGTM

The change is correct and minimal:

  • The lance-namespace-datafusion crate was already a workspace member (line 16 of Cargo.toml)
  • It was missing from [workspace.dependencies], which broke version bumping
  • The new entry is correctly placed in alphabetical order between lance-namespace-impls and lance-namespace-reqwest-client
  • The version matches the workspace version (2.1.0-beta.0)

No concerns with this fix.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@majin1102 majin1102 changed the title fix: fix bumpversion failed fix: fix bump version failed Feb 3, 2026
@wjones127 wjones127 changed the title fix: fix bump version failed ci: fix bump version failed Feb 3, 2026
@github-actions github-actions Bot added the ci Github Action or Test issues label Feb 3, 2026
@wjones127 wjones127 merged commit 824c05f into lance-format:main Feb 3, 2026
31 checks passed
@majin1102 majin1102 deleted the fix-publish branch February 4, 2026 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci Github Action or Test issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants