fix: avoid bitmap range panic on inverted bounds#5893
Merged
wjones127 merged 1 commit intolance-format:mainfrom Feb 5, 2026
Merged
fix: avoid bitmap range panic on inverted bounds#5893wjones127 merged 1 commit intolance-format:mainfrom
wjones127 merged 1 commit intolance-format:mainfrom
Conversation
Contributor
Author
|
PTAL @wjones127 |
wjones127
approved these changes
Feb 5, 2026
Contributor
wjones127
left a comment
There was a problem hiding this comment.
Looks reasonable. I'm a little surprised those expressions are just simplified to false by the expression optimizer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #5878
Problem
BITMAP index panics when receiving inverted range queries like
BETWEEN 2 AND 1orx > 2 AND x < 2. This is becauseBTreeMap::range()panics whenstart > endor when both bounds are Excluded at the same value.Solution
Add range validation matching BTREE's existing behavior:
[a, b]: empty ifa > b[a, b),(a, b],(a, b): empty ifa >= bReturns empty result for empty ranges instead of panicking.