fix: split index_statistics to reduce rustc query depth#5894
fix: split index_statistics to reduce rustc query depth#5894Xuanwo merged 2 commits intolance-format:mainfrom
Conversation
Code ReviewThis is a well-structured refactoring that addresses the rustc query depth overflow issue when compiling with nightly + coverage instrumentation. SummaryThe PR successfully breaks down the large
VerificationThe behavior is preserved correctly. I noted that the original code tracked LGTM ✓ |
This avoids rustc 'queries overflow the depth limit' errors in nightly llvm-cov builds by boxing a few deep futures so the async state machines stay small.
westonpace
left a comment
There was a problem hiding this comment.
Thanks for investigating into this. I saw the CI error and had no idea what to do 😆. I have a few naming nits but they aren't absolutely required.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
e457959 to
62658cd
Compare
Use clearer helper names per review feedback.
Cherry-pick from main to fix CI recursion limit error. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Cherry-pick from main to fix CI recursion limit error. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This refactors
DatasetIndexExt::index_statisticsinto smaller helper functions to reduce the async state-machine complexity.This avoids
rustcquery depth overflow when compiling with nightly + coverage instrumentation and many enabled features.Parts of this PR were drafted with assistance from Codex (with
gpt-5.2) and fully reviewed and edited by me. I take full responsibility for all changes.