feat(python): expose enable_stable_row_ids in commit()#5908
Merged
wjones127 merged 2 commits intolance-format:mainfrom Feb 12, 2026
Merged
feat(python): expose enable_stable_row_ids in commit()#5908wjones127 merged 2 commits intolance-format:mainfrom
wjones127 merged 2 commits intolance-format:mainfrom
Conversation
…t_transaction()` Allow setting `enable_stable_row_ids` when creating a dataset via the `commit()` path, enabling atomic creation of datasets with stable row IDs. The parameter is threaded through Python → PyO3 → CommitBuilder. Closes lance-format#5906
|
@fecet any estimated date to merge this PR? |
wjones127
requested changes
Feb 11, 2026
fecet
commented
Feb 12, 2026
Contributor
Author
fecet
left a comment
fecet
left a comment
There was a problem hiding this comment.
Addressed: updated the docstring to clarify that enable_stable_row_ids only applies when creating a new dataset.
wjones127
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enable_stable_row_idsparameter inLanceDataset.commit()andcommit_transaction(), allowing atomic creation of datasets with stable row IDs via the commit path.CommitBuilder.use_stable_row_ids().Closes #5906
Test plan
cargo check -p pylancepassescargo clippy -p pylancepasses with no warningstest_commit_with_stable_row_idsverifies thatcommit(Overwrite, enable_stable_row_ids=True)creates a dataset with sequential stable row IDs across append