Skip to content

refactor: correct panic message typos in OrderableScalarValue::cmp #5913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wjones127 merged 1 commit into from
Feb 10, 2026
Merged

refactor: correct panic message typos in OrderableScalarValue::cmp #5913

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rust/lance-index/src/scalar/btree.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ impl Ord for OrderableScalarValue {
Ordering::Greater
}
}
(Int64(_), _) => panic!("Attempt to compare Int16 with non-Int64"),
(Int64(_), _) => panic!("Attempt to compare Int64 with non-Int64"),
(UInt8(v1), UInt8(v2)) => v1.cmp(v2),
(UInt8(v1), Null) => {
if v1.is_none() {
Expand Down Expand Up @@ -307,7 +307,7 @@ impl Ord for OrderableScalarValue {
Ordering::Greater
}
}
(UInt64(_), _) => panic!("Attempt to compare Int16 with non-UInt64"),
(UInt64(_), _) => panic!("Attempt to compare UInt64 with non-UInt64"),
(Utf8(v1) | Utf8View(v1) | LargeUtf8(v1), Utf8(v2) | Utf8View(v2) | LargeUtf8(v2)) => {
v1.cmp(v2)
}
Expand Down
Loading