fix: avoid panic on empty list LABEL_LIST filters#5914
Merged
wjones127 merged 4 commits intolance-format:mainfrom Feb 10, 2026
Merged
fix: avoid panic on empty list LABEL_LIST filters#5914wjones127 merged 4 commits intolance-format:mainfrom
wjones127 merged 4 commits intolance-format:mainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Hi @westonpace, could you please review this when you have a moment? Thanks! |
wjones127
approved these changes
Feb 10, 2026
wjones127
added a commit
to wjones127/lance
that referenced
this pull request
Feb 10, 2026
LabelList index still has issues with null element handling despite PR lance-format#5867 and PR lance-format#5914. Tests pass without LabelList index. Re-enable when fully fixed. Issue: lance-format#5682 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
array_has_any/all(labels, [])yields an empty label-list query; LabelList index merge (set_union/set_intersection)unwrapsthe first element and panics on an empty iterator.Skip LABEL_LIST index parsing for empty lists to avoid the panic and fall back to normal execution.