Skip to content

feat: add third party licenses lists#5922

Merged
jackye1995 merged 2 commits intolance-format:mainfrom
jackye1995:license-check
Feb 10, 2026
Merged

feat: add third party licenses lists#5922
jackye1995 merged 2 commits intolance-format:mainfrom
jackye1995:license-check

Conversation

@jackye1995
Copy link
Copy Markdown
Contributor

@jackye1995 jackye1995 commented Feb 9, 2026

The files are generated with make licenses, currently expected to run manually. In the future, some automations could be built.

@github-actions github-actions Bot added enhancement New feature or request python java labels Feb 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 9, 2026

PR Review: feat: add third party licenses lists

This PR adds license generation tooling for Rust, Python, and Java dependencies. Overall this is a good addition for license compliance.

P1 Issues

  1. Incorrect intro text in the generated HTML template (about.hbs line 42):

    <p>This page lists the licenses of the projects used in cargo-about.</p>

    This should reference Lance, not cargo-about. Consider changing to:

    <p>This page lists the licenses of the third-party projects used in Lance.</p>
  2. Large generated files checked into git: The three RUST_THIRD_PARTY_LICENSES.html files add ~47K lines of generated HTML to the repository. Consider:

    • Adding these to .gitignore and generating them only during release/packaging
    • Or documenting in the PR description why these need to be version-controlled

Minor Observations (non-blocking)

  • The PYTHON_THIRD_PARTY_LICENSES.md lists some packages with UNKNOWN license (e.g., arro3-core, geoarrow-rust-core). This is informational - these may need manual verification.
  • The Makefile assumes uv is installed for Python license generation - this is reasonable given the project setup.

@jackye1995 jackye1995 merged commit 9551d14 into lance-format:main Feb 10, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request java python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants