Skip to content

fix: open additional storage options provider related apis in lance dataset#5932

Merged
jackye1995 merged 2 commits intorelease/v2.0from
backport/pr-5869-to-release-v2.0
Feb 11, 2026
Merged

fix: open additional storage options provider related apis in lance dataset#5932
jackye1995 merged 2 commits intorelease/v2.0from
backport/pr-5869-to-release-v2.0

Conversation

@lance-community
Copy link
Copy Markdown
Contributor

Backport of #5869

This PR backports the changes from the original PR to the release/v2.0 branch.

@github-actions github-actions Bot added bug Something isn't working python labels Feb 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

PR Review

Summary

This backport of #5869 propagates the storage_options_provider attribute through various LanceDataset construction paths and adds a new_file_session() method for credential management.

P1 - Formatting Issue

Missing blank line between methods in the diff:

+            storage_options_provider=self._storage_options_provider,
+        )
     def checkout_version(

There should be a blank line between new_file_session() and checkout_version() to follow PEP 8 style guidelines. This may cause linting failures.

Test Coverage

The PR adds a new public API (new_file_session()) without corresponding tests. While the original PR (#5869) also lacked tests for this method, it would be valuable to add at least a basic test to verify the method returns a properly configured LanceFileSession.


Generated by Claude Code review

@jackye1995 jackye1995 merged commit 450e00c into release/v2.0 Feb 11, 2026
13 checks passed
@jackye1995 jackye1995 deleted the backport/pr-5869-to-release-v2.0 branch February 11, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants