Skip to content

docs: add lance-trino doc#5943

Merged
jackye1995 merged 1 commit intolance-format:mainfrom
jackye1995:trino-doc
Feb 12, 2026
Merged

docs: add lance-trino doc#5943
jackye1995 merged 1 commit intolance-format:mainfrom
jackye1995:trino-doc

Conversation

@jackye1995
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Feb 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

PR Review: docs: add lance-trino doc

Summary: This PR adds the lance-trino documentation to the docs deployment workflow, following the same pattern used for other integrations (lance-spark, lance-ray, lance-huggingface).

Issues Found

P1 - Repository Organization Inconsistency:
The PR checks out from lance-format/lance-trino but the existing .pages file references lancedb/lance-trino. Please verify which organization the repository actually lives in:

  • If the repo is at lance-format/lance-trino: the changes are correct
  • If the repo is at lancedb/lance-trino: the checkout should use lancedb/lance-trino instead

Other integration repos show a mix of organizations:

  • lancedb/lance-spark, lancedb/lance-namespace, lancedb/lance-ray
  • lance-format/lance-huggingface, lance-format/lance-namespace-impls

P1 - Missing Error Handling:
Unlike lance-namespace-impls which uses || true for the CONTRIBUTING.md copy (line 113), the lance-trino CONTRIBUTING.md copy has no fallback:

cp lance-trino/CONTRIBUTING.md docs/src/community/project-specific/trino.md

If the file doesn't exist in the lance-trino repo, the workflow will fail. Consider adding || true for consistency.


The overall pattern and structure follows the existing conventions well.

Copy link
Copy Markdown
Contributor

@justinrmiller justinrmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Copy link
Copy Markdown
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jackye1995 jackye1995 merged commit 75622b1 into lance-format:main Feb 12, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants