feat: update minimum supported rust version from 1.88 to 1.91#5964
Merged
westonpace merged 1 commit intolance-format:mainfrom Feb 18, 2026
Merged
feat: update minimum supported rust version from 1.88 to 1.91#5964westonpace merged 1 commit intolance-format:mainfrom
westonpace merged 1 commit intolance-format:mainfrom
Conversation
Contributor
PR ReviewThis is a clean MSRV bump from 1.88 to 1.91 across all relevant files:
No issues found. The changes are consistent across all files and the rationale (AWS libraries MSRV update + DataFusion's 4-release/4-month policy) is sound. LGTM ✓ |
hamersaw
approved these changes
Feb 18, 2026
wjones127
approved these changes
Feb 18, 2026
Xuanwo
approved these changes
Feb 18, 2026
Member
Author
|
The native-tls failure looks transient (maintainer yanked that version, looks like an accidental bad publish). I've confirmed no error with 0.2.18 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AWS libraries have updated their MSRV to 1.91 and their versioning scheme makes it a little difficult to pin. We aim to follow Datafusion's policy which is "4 minor releases and 4 months". The release of 1.94 (currently slated for 5 Mar) would make 1.91 the minimum (1.91 is released in October so we have 4 months and this gives us 4 releases (1.91, 1.92, 1.93, 1.94).
Since 5 Mar is close I'd rather not dive into complicated pinning too much even if we are technically getting ahead of ourselves slightly.