feat: add Dataset::with_object_store for request-scoped store overrides#5966
Merged
wjones127 merged 1 commit intolance-format:mainfrom Feb 18, 2026
Merged
Conversation
Add Dataset::with_object_store so callers can clone a dataset bound to a caller-supplied ObjectStore. This is useful for tracking metrics on a per-request basis. For example, if you have an object store wrapper that performs caching, you can create a freshly wrapped object store for each use of the dataset in order to collect per-request hit/miss tallies.
cmccabe
approved these changes
Feb 18, 2026
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Dataset::with_object_store so callers can clone a dataset bound to a caller-supplied ObjectStore. This is useful for tracking metrics on a per-request basis.
For example, if you have an object store wrapper that performs caching, you can create a freshly wrapped object store for each use of the dataset in order to collect per-request hit/miss tallies.