Skip to content

chore: fix test compile error#5975

Merged
westonpace merged 2 commits intolance-format:mainfrom
westonpace:fix/compiler-err-after-merge
Feb 21, 2026
Merged

chore: fix test compile error#5975
westonpace merged 2 commits intolance-format:mainfrom
westonpace:fix/compiler-err-after-merge

Conversation

@westonpace
Copy link
Copy Markdown
Member

@github-actions
Copy link
Copy Markdown
Contributor

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@westonpace westonpace changed the title Fix compile error chore: fix test compile error Feb 21, 2026
@github-actions github-actions Bot added the chore label Feb 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Code Review

LGTM

This is a straightforward fix for a compile error caused by merge sequencing. The change correctly adds the required progress parameter to the build_scalar_index call using NoopIndexBuildProgress, which is the appropriate no-op implementation for this context.

No issues found.

@westonpace
Copy link
Copy Markdown
Member Author

I'm headed out for a bit so if anyone approves this feel free to merge

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@westonpace westonpace merged commit daeb258 into lance-format:main Feb 21, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants