You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR aligns the RestNamespace implementation with the Lance namespace spec, changing HTTP methods and paths for list_table_versions and describe_table_version APIs.
Potential Issue (P1)
list_table_versions body serialization (rest.rs:1189):
Passing &() as the body will serialize to JSON null. If the server expects an empty object {} or validates that the body is not null, this could cause runtime failures. Consider:
Confirming the spec allows null body for this POST endpoint, OR
Using an empty struct or serde_json::Value::Object that serializes to {} if needed
Minor Observations
No test coverage for changed endpoints: The list_table_versions and describe_table_version methods don't have dedicated tests with wiremock. Consider adding tests that validate the HTTP method (POST), path (/version/list, /version/describe), and body format to prevent future regressions.
Python create_table_version_json additions: The new JSON wrapper methods look correct for Rust FFI compatibility. The pattern matches similar methods in the codebase.
jackye1995
changed the title
fix: table version api drift from lance namespace spec
fix: rest namespace integration with table version apis
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During testing, found some issue with
RestNamespaceimplementation of the table versions API, which was not 100% according to the spec definition.