feat: add ability to pass custom headers to objectstore requests#5989
Merged
Xuanwo merged 7 commits intolance-format:mainfrom Feb 26, 2026
Merged
Conversation
Signed-off-by: Daniel Rammer <hamersaw@protonmail.com>
Signed-off-by: Daniel Rammer <hamersaw@protonmail.com>
Signed-off-by: Daniel Rammer <hamersaw@protonmail.com>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
…cedent Signed-off-by: Daniel Rammer <hamersaw@protonmail.com>
eddyxu
requested review from
jackye1995,
westonpace and
wjones127
and removed request for
wjones127
Xuanwo
approved these changes
Feb 26, 2026
jackye1995
pushed a commit
to wjones127/lance
that referenced
this pull request
Feb 26, 2026
…ce-format#5989) This PR lets you pass custom headers through to the `object_store` HTTP requests. These are provided using the regular `storageOptions`. For example: ``` storage.account_name=foo storage.headers.x-priority=high storage.headers.x-foo=bar ``` Would set the header "x-priority" to "high" and "x-foo" to "bar". Closes lance-format#5643. --------- Signed-off-by: Daniel Rammer <hamersaw@protonmail.com>
wjones127
pushed a commit
that referenced
this pull request
Feb 26, 2026
This PR lets you pass custom headers through to the `object_store` HTTP requests. These are provided using the regular `storageOptions`. For example: ``` storage.account_name=foo storage.headers.x-priority=high storage.headers.x-foo=bar ``` Would set the header "x-priority" to "high" and "x-foo" to "bar". Closes #5643. --------- Signed-off-by: Daniel Rammer <hamersaw@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lets you pass custom headers through to the
object_storeHTTP requests. These are provided using the regularstorageOptions. For example:Would set the header "x-priority" to "high" and "x-foo" to "bar".
Closes #5643.