fix: various bugs to namespace access#5996
Conversation
jackye1995
commented
Feb 24, 2026
- fix python binding short-circuit for DirectoryNamespace and RestNamespace binding
- fix local file system access to LanceFileSession for namespace-based access
- fix propagating storage options to __manifest table in DirectoryNamespace
Code Review for PR #5996SummaryThis PR fixes three bugs in namespace access: Python binding short-circuit for wrapper classes, local file system Writer::shutdown, and storage options propagation in DirectoryNamespace. P1: Missing TestsPer the project guidelines: "We do not merge code without tests." The PR fixes three bugs but doesn't include tests for:
Please add tests that verify these fixes work correctly. P1: Code Duplication in
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
1. fix python binding short-circuit for DirectoryNamespace and RestNamespace binding 2. fix local file system access to LanceFileSession for namespace-based access 3. fix propagating storage options to __manifest table in DirectoryNamespace
1. fix python binding short-circuit for DirectoryNamespace and RestNamespace binding 2. fix local file system access to LanceFileSession for namespace-based access 3. fix propagating storage options to __manifest table in DirectoryNamespace
1. fix python binding short-circuit for DirectoryNamespace and RestNamespace binding 2. fix local file system access to LanceFileSession for namespace-based access 3. fix propagating storage options to __manifest table in DirectoryNamespace