docs: clarify v2.2 nested drop rollback risk#5999
Merged
Conversation
github-actions
Bot
added
the
documentation
Contributor
Code ReviewSummary: Documentation-only change adding clarification about v2.2 nested sub-column drops and operational guidance for rollback windows. VerificationI verified the v2.2 claim against the test code in
Review ResultNo P0/P1 issues found. The documentation is factually accurate and the warning about data becoming unrecoverable after LGTM ✓ |
westonpace
approved these changes
Feb 24, 2026
Member
westonpace
left a comment
westonpace
left a comment
There was a problem hiding this comment.
One minor nit, good otherwise
Comment on lines
+161
to
+163
| Starting with Lance file format `2.2`, nested sub-column removal is supported for | ||
| nested types (for example `people.item.city` on `list<struct<...>>`), instead of | ||
| being limited to `struct` only. |
Member
There was a problem hiding this comment.
Minor nit: could you move this paragraph above the previous one? Right now this breaks up the structure a little...
- To actually cleanup use
cleanup_old_versions - Did you know, in newer versions, you can now delete nested subfields
- Warning! If you cleanup, you might delete actual data and make rollback impossible
wjones127
pushed a commit
to wjones127/lance
that referenced
this pull request
Feb 25, 2026
- add a warning that `drop_columns` is metadata-only but data can become unrecoverable after `compact_files` + `cleanup_old_versions` - add operational guidance for rollback windows (tag/snapshot, delayed cleanup, validation before aggressive cleanup) --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.3-codex`) and fully reviewed and edited by me. I take full responsibility for all changes.**
wjones127
pushed a commit
to wjones127/lance
that referenced
this pull request
Feb 25, 2026
- add a warning that `drop_columns` is metadata-only but data can become unrecoverable after `compact_files` + `cleanup_old_versions` - add operational guidance for rollback windows (tag/snapshot, delayed cleanup, validation before aggressive cleanup) --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.3-codex`) and fully reviewed and edited by me. I take full responsibility for all changes.**
wjones127
pushed a commit
that referenced
this pull request
Feb 26, 2026
- add a warning that `drop_columns` is metadata-only but data can become unrecoverable after `compact_files` + `cleanup_old_versions` - add operational guidance for rollback windows (tag/snapshot, delayed cleanup, validation before aggressive cleanup) --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.3-codex`) and fully reviewed and edited by me. I take full responsibility for all changes.**
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
drop_columnsis metadata-only but data can become unrecoverable aftercompact_files+cleanup_old_versionsParts of this PR were drafted with assistance from Codex (with
gpt-5.3-codex) and fully reviewed and edited by me. I take full responsibility for all changes.