feat: add DeleteResult with num_deleted_rows#6001
Merged
wjones127 merged 3 commits intolance-format:mainfrom Feb 24, 2026
Merged
feat: add DeleteResult with num_deleted_rows#6001wjones127 merged 3 commits intolance-format:mainfrom
wjones127 merged 3 commits intolance-format:mainfrom
Conversation
This introduces a DeleteResult with num_rows_deleted, similar to UpdateResult.
wjones127
requested changes
Feb 24, 2026
Contributor
wjones127
left a comment
wjones127
left a comment
There was a problem hiding this comment.
One small change needed, otherwise seems good.
Co-authored-by: Will Jones <willjones127@gmail.com>
Contributor
Author
|
@wjones127 thanks, committed your suggestion |
wjones127
approved these changes
Feb 24, 2026
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
wjones127
added a commit
to wjones127/lance
that referenced
this pull request
Feb 25, 2026
This introduces a DeleteResult with num_rows_deleted, similar to UpdateResult. --------- Co-authored-by: Will Jones <willjones127@gmail.com>
wjones127
added a commit
to wjones127/lance
that referenced
this pull request
Feb 25, 2026
This introduces a DeleteResult with num_rows_deleted, similar to UpdateResult. --------- Co-authored-by: Will Jones <willjones127@gmail.com>
wjones127
added a commit
that referenced
this pull request
Feb 26, 2026
This introduces a DeleteResult with num_rows_deleted, similar to UpdateResult. --------- Co-authored-by: Will Jones <willjones127@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a DeleteResult with num_rows_deleted, similar to UpdateResult.