fix: set namespace commit handler for LanceDataset.commit#6002
Merged
jackye1995 merged 2 commits intolance-format:mainfrom Feb 24, 2026
Merged
fix: set namespace commit handler for LanceDataset.commit#6002jackye1995 merged 2 commits intolance-format:mainfrom
jackye1995 merged 2 commits intolance-format:mainfrom
Conversation
Contributor
Code ReviewP1: Missing validation for namespace/table_id pairThe commit method changes add In if (namespace is None) != (table_id is None):
raise ValueError("Both 'namespace' and 'table_id' must be provided together.")This follows the existing pattern in the codebase (see Minor noteThe namespace extraction logic in |
ac85e09 to
5394044
Compare
jackye1995
commented
Feb 24, 2026
| "-Wclippy::string_add_assign", | ||
| "-Wclippy::string_add", | ||
| "-Wclippy::string_lit_as_bytes", | ||
| "-Wclippy::string_to_string", |
Contributor
Author
There was a problem hiding this comment.
depreacted clippy lint
5394044 to
9cd646a
Compare
The clippy::string_to_string lint was removed in recent Rust versions. Removing it from the config fixes the CI lint failure. Also refactored extract_namespace_arc into a shared utility function in namespace.rs to reduce code duplication. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
9cd646a to
29d2605
Compare
hamersaw
approved these changes
Feb 24, 2026
wjones127
approved these changes
Feb 24, 2026
wjones127
pushed a commit
to wjones127/lance
that referenced
this pull request
Feb 25, 2026
…at#6002) Also added helper function `extract_namespace_arc` for shared logic --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
wjones127
pushed a commit
to wjones127/lance
that referenced
this pull request
Feb 25, 2026
…at#6002) Also added helper function `extract_namespace_arc` for shared logic --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
wjones127
pushed a commit
that referenced
this pull request
Feb 26, 2026
Also added helper function `extract_namespace_arc` for shared logic --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added helper function
extract_namespace_arcfor shared logic