fix: fast_search should ignore any unindexed data for vector search#6007
Merged
fix: fast_search should ignore any unindexed data for vector search#6007
Conversation
Contributor
Code ReviewLGTM - This is a clean, minimal fix. SummaryThe PR correctly aligns vector search behavior with the existing FTS behavior (scanner.rs:3369-3371) when Verification
No issues found. |
Xuanwo
approved these changes
Feb 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
wjones127
pushed a commit
to wjones127/lance
that referenced
this pull request
Feb 25, 2026
…ance-format#6007) Before this, lance still performs flat search if there's no vector index.
wjones127
pushed a commit
to wjones127/lance
that referenced
this pull request
Feb 25, 2026
…ance-format#6007) Before this, lance still performs flat search if there's no vector index.
wjones127
pushed a commit
that referenced
this pull request
Feb 26, 2026
…6007) Before this, lance still performs flat search if there's no vector index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this, lance still performs flat search if there's no vector index.