fix: correctly calculate max visible level when a list has no def#6008
Merged
westonpace merged 2 commits intolance-format:mainfrom Feb 25, 2026
Merged
Conversation
Member
Author
|
For review, probably just look at the test cases and ensure they make sense. |
Contributor
Code ReviewP0: Debug print statement left in code There is a The fix itself (adding |
Collaborator
|
Thank you for working on this! |
Xuanwo
approved these changes
Feb 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
wjones127
pushed a commit
to wjones127/lance
that referenced
this pull request
Feb 25, 2026
…nce-format#6008) This was a bug that would be encountered whenever a list had nullable items (struct or otherwise) but the list itself was never null and never empty. The unraveler was incorrectly skipping offsets and returning fewer lists than it should. This was a reader-only bug. No corrupt data would have been written. Closes lance-format#5930
wjones127
pushed a commit
to wjones127/lance
that referenced
this pull request
Feb 25, 2026
…nce-format#6008) This was a bug that would be encountered whenever a list had nullable items (struct or otherwise) but the list itself was never null and never empty. The unraveler was incorrectly skipping offsets and returning fewer lists than it should. This was a reader-only bug. No corrupt data would have been written. Closes lance-format#5930
wjones127
pushed a commit
that referenced
this pull request
Feb 26, 2026
) This was a bug that would be encountered whenever a list had nullable items (struct or otherwise) but the list itself was never null and never empty. The unraveler was incorrectly skipping offsets and returning fewer lists than it should. This was a reader-only bug. No corrupt data would have been written. Closes #5930
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a bug that would be encountered whenever a list had nullable items (struct or otherwise) but the list itself was never null and never empty. The unraveler was incorrectly skipping offsets and returning fewer lists than it should.
This was a reader-only bug. No corrupt data would have been written.
Closes #5930