Skip to content

test: add v2.2 format gate regression tests#6012

Merged
Xuanwo merged 2 commits intomainfrom
xuanwo/v22-p1-gate-tests
Feb 26, 2026
Merged

test: add v2.2 format gate regression tests#6012
Xuanwo merged 2 commits intomainfrom
xuanwo/v22-p1-gate-tests

Conversation

@Xuanwo
Copy link
Copy Markdown
Collaborator

@Xuanwo Xuanwo commented Feb 25, 2026

  • add a regression test that rejects writing Blob v2 data with file version 2.1
  • add a regression test that rejects FixedSizeList<Struct> encoding with file version 2.1
  • add a regression test that ensures requested general compression is not selected for file version 2.1

Parts of this PR were drafted with assistance from Codex (with gpt-5.2) and fully reviewed and edited by me. I take full responsibility for all changes.

@github-actions github-actions Bot added the chore label Feb 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Review Summary

LGTM - Clean, well-structured regression tests for v2.2 format gates.

No P0/P1 issues found. The tests properly verify that:

  • General compression is not selected for V2.1 even when requested
  • FixedSizeList<Struct> encoding is rejected for V2.1
  • Blob v2 writes are rejected for V2.1

Minor note: The #[cfg(any(feature = "lz4", feature = "zstd"))] attribute on the compression test is a good practice to avoid test failures when neither compression feature is enabled.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 25, 2026

Codecov Report

❌ Patch coverage is 98.43750% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance-encoding/src/compression.rs 93.75% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@Xuanwo Xuanwo merged commit 025f37f into main Feb 26, 2026
29 checks passed
@Xuanwo Xuanwo deleted the xuanwo/v22-p1-gate-tests branch February 26, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants