fix: make overwrites retryable instead of compatible#6014
Merged
jackye1995 merged 8 commits intolance-format:mainfrom Feb 25, 2026
Merged
fix: make overwrites retryable instead of compatible#6014jackye1995 merged 8 commits intolance-format:mainfrom
jackye1995 merged 8 commits intolance-format:mainfrom
Conversation
Contributor
Code ReviewSummary: This PR correctly changes overwrite conflict semantics for better Snapshot isolation: two concurrent creates ( Review Result: ✅ Looks good to merge The logic is sound:
Test coverage is adequate:
No P0/P1 issues identified. |
wjones127
approved these changes
Feb 25, 2026
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
wjones127
pushed a commit
to wjones127/lance
that referenced
this pull request
Feb 25, 2026
From a Snapshot isolation perspective, 2 overwrites should not just be compatible because they have modified overlapping data between 2 writes. We will mark it as retryable and client can make a decision if it can be retried or not depending on the specific case.
wjones127
pushed a commit
to wjones127/lance
that referenced
this pull request
Feb 25, 2026
From a Snapshot isolation perspective, 2 overwrites should not just be compatible because they have modified overlapping data between 2 writes. We will mark it as retryable and client can make a decision if it can be retried or not depending on the specific case.
wjones127
pushed a commit
that referenced
this pull request
Feb 26, 2026
From a Snapshot isolation perspective, 2 overwrites should not just be compatible because they have modified overlapping data between 2 writes. We will mark it as retryable and client can make a decision if it can be retried or not depending on the specific case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From a Snapshot isolation perspective, 2 overwrites should not just be compatible because they have modified overlapping data between 2 writes. We will mark it as retryable and client can make a decision if it can be retried or not depending on the specific case.