docs: require data_storage_version=2.2 in map type example#6032
Merged
Conversation
Co-authored-by: Codex
github-actions
Bot
added
the
documentation
Contributor
|
LGTM! This is a clear documentation fix that prevents users from copying an example that would fail with the default settings. No concerns - docs-only change that improves user experience. |
BubbleCal
approved these changes
Feb 27, 2026
wjones127
pushed a commit
to wjones127/lance
that referenced
this pull request
Mar 4, 2026
…mat#6032) ## Summary - update the Map type guide example to explicitly set `data_storage_version="2.2"` - add a short note that Map writes require Lance file format version 2.2 or later ## Why Map writes are only supported with file format 2.2+, and writing with 2.1 fails in tests. The previous example used default settings, which can be copied by users into a failing workflow. --- **Parts of this PR were drafted with assistance from Codex (with `gpt-5.3-codex`) and fully reviewed and edited by me. I take full responsibility for all changes.**
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data_storage_version="2.2"Why
Map writes are only supported with file format 2.2+, and writing with 2.1 fails in tests. The previous example used default settings, which can be copied by users into a failing workflow.
Parts of this PR were drafted with assistance from Codex (with
gpt-5.3-codex) and fully reviewed and edited by me. I take full responsibility for all changes.