feat(java): expose prefilter parameter to support vector search with fragments#6040
Merged
Xuanwo merged 3 commits intolance-format:mainfrom Mar 6, 2026
Merged
feat(java): expose prefilter parameter to support vector search with fragments#6040Xuanwo merged 3 commits intolance-format:mainfrom
Xuanwo merged 3 commits intolance-format:mainfrom
Conversation
Contributor
Author
|
@jackye1995 Hi, could you please take a look at this PR when you have a moment? This pr is for lance-format/lance-spark#189 |
Contributor
Author
|
Hi, @jackye1995 It’s a relatively short diff. so it shouldn't take much of your time. Could you please give it a quick review when you're free.Thank you! |
Xuanwo
approved these changes
Mar 4, 2026
Collaborator
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
Contributor
Author
|
@Xuanwo Thanks for the review. I've fixed the flaky UTs |
hamersaw
added a commit
to lance-format/lance-spark
that referenced
this pull request
Mar 30, 2026
When performing vector queries, if a specific fragment is targeted, prefilter must be set to true to ensure correct execution. Vector queries are pushed down to shards for execution, but the returned Top-K results consist of K × number of shards records, which require manual processing by the business layer. #189 [lance-pr](lance-format/lance#6040) --------- Co-authored-by: niuyulin <niuyulin@chinamobile.com> Co-authored-by: Daniel Rammer <hamersaw@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In lance-spark, distributed vector queries rely on fragmentScanner. When a specific fragment is targeted, prefilter must be set to true to ensure correct execution. This change exposes the variable through JNI to enable this functionality.