feat: surface ambiguous merge insert error as InvalidInput#6048
Merged
wjones127 merged 3 commits intolance-format:mainfrom Feb 27, 2026
Merged
feat: surface ambiguous merge insert error as InvalidInput#6048wjones127 merged 3 commits intolance-format:mainfrom
InvalidInput#6048wjones127 merged 3 commits intolance-format:mainfrom
Conversation
Contributor
ReviewNo P0 or P1 issues found. The changes are clean and correct.
Nit (non-blocking): The two LGTM. |
wjones127
added a commit
to wjones127/lance
that referenced
this pull request
Mar 4, 2026
…ormat#6048) Make ambiguous merge insert surfaced as `InvalidInput` and make the error message clearer that it aborted the write and not that data corruption might have already happened.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make ambiguous merge insert surfaced as
InvalidInputand make the error message clearer that it aborted the write and not that data corruption might have already happened.