Skip to content

feat: surface ambiguous merge insert error as InvalidInput#6048

Merged
wjones127 merged 3 commits intolance-format:mainfrom
wjones127:chore-improve-error-message
Feb 27, 2026
Merged

feat: surface ambiguous merge insert error as InvalidInput#6048
wjones127 merged 3 commits intolance-format:mainfrom
wjones127:chore-improve-error-message

Conversation

@wjones127
Copy link
Copy Markdown
Contributor

Make ambiguous merge insert surfaced as InvalidInput and make the error message clearer that it aborted the write and not that data corruption might have already happened.

@github-actions github-actions Bot added the enhancement New feature or request label Feb 27, 2026
@wjones127 wjones127 requested a review from wkalt February 27, 2026 17:12
@github-actions
Copy link
Copy Markdown
Contributor

Review

No P0 or P1 issues found. The changes are clean and correct.

handle_stream_processing_error — sending error to only one channel: This is safe because the two streams are consumed via .chain() (create_ordered_update_insert_stream, line 373), so an error yielded from update_stream will abort before insert_stream is ever polled. The fallback path (sending to insert_tx when update_tx's receiver is already dropped) correctly preserves the original error.

Nit (non-blocking): The two return; statements in handle_stream_processing_error are redundant since the function returns at the end of the match anyway.

LGTM.

Copy link
Copy Markdown
Contributor

@wkalt wkalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending CI

@wjones127 wjones127 merged commit 1193956 into lance-format:main Feb 27, 2026
27 of 28 checks passed
wjones127 added a commit to wjones127/lance that referenced this pull request Mar 4, 2026
…ormat#6048)

Make ambiguous merge insert surfaced as `InvalidInput` and make the
error message clearer that it aborted the write and not that data
corruption might have already happened.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants