Skip to content

fix: pin substrait to 0.62.2 until DF supports 0.62.3#6121

Merged
westonpace merged 2 commits intolance-format:mainfrom
westonpace:fix/pin-substrait-0-62-2
Mar 6, 2026
Merged

fix: pin substrait to 0.62.2 until DF supports 0.62.3#6121
westonpace merged 2 commits intolance-format:mainfrom
westonpace:fix/pin-substrait-0-62-2

Conversation

@westonpace
Copy link
Copy Markdown
Member

No description provided.

@github-actions github-actions Bot added the bug Something isn't working label Mar 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2026

Review

Clean, minimal fix. Two suggestions:

  1. Add a comment linking the upstream issue. The comment says "pin substrait to 0.62.2 for now" but doesn't link to a tracking issue (DataFusion or substrait-rs) so there's no way to know when this pin can be removed. Please add a link (e.g., // See https://github.com/apache/datafusion/issues/XXXX) so this doesn't become stale tech debt.

  2. The substrait dep in Cargo.lock appears unconditionally. The diff shows substrait added to the lock file's lance-datafusion entry without being gated behind the substrait feature. Since it's declared optional = true in Cargo.toml, verify that cargo build without the substrait feature doesn't pull it in — it should be fine given optional = true, but the lock diff is worth double-checking since the lock file sometimes flattens optional deps.

Otherwise the approach (pinning via an explicit optional dep) is reasonable as a short-term workaround. LGTM once the upstream issue link is added.

@github-actions github-actions Bot added the python label Mar 6, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@westonpace westonpace merged commit ee23cfa into lance-format:main Mar 6, 2026
28 checks passed
@westonpace
Copy link
Copy Markdown
Member Author

apache/datafusion#20756 for tracking upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants