fix: vector index type shown as unknown in describe_indices#6122
fix: vector index type shown as unknown in describe_indices#6122Xuanwo merged 3 commits intolance-format:mainfrom
Conversation
PR ReviewSummary: Opens vector indices to determine their concrete type (e.g., IVF_PQ, IVF_HNSW_SQ) instead of showing "Unknown" in Performance concern (P1)
Consider:
Missing tests (P1)Per repo policy: "All bugfixes and features must have corresponding tests." There are no tests added for this change. A test that creates a vector index (e.g., IVF_PQ) and asserts Minor: variable shadowing replaced but
|
justinrmiller
left a comment
There was a problem hiding this comment.
looks good, my only concern is if the collect gets too large, but that also applies to the previous version.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
FYI this will also be fixed by #6099, but that will take longer to merge. |
Nice, totally agree that's the right way. I guess the question is do we think this is a regression so we should have this in place first. But if we are not patching it, then it does not really make much sense |
Vector index still needs to be opened to get the right type, otherwise it is shown as unknown.