Skip to content

chore: clippy cleanups#6172

Merged
Xuanwo merged 1 commit intomainfrom
xuanwo/fix-clippy-cleanups
Mar 12, 2026
Merged

chore: clippy cleanups#6172
Xuanwo merged 1 commit intomainfrom
xuanwo/fix-clippy-cleanups

Conversation

@Xuanwo
Copy link
Copy Markdown
Collaborator

@Xuanwo Xuanwo commented Mar 12, 2026

This PR moves a few unrelated clippy cleanups out of #6168 so the blob empty-range fix can stay focused on the regression it addresses. The changes here are all mechanical simplifications with no intended behavior change.

@github-actions github-actions Bot added the chore label Mar 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Code Review

Clean, mechanical clippy fixes — all changes are straightforward and behavior-preserving. No issues found.

The is_some() + unwrap() → pattern matching conversions are correct, the Self usage in the enum is idiomatic, get_or_insert_with is the right tool for the lazy-init pattern in tests, and the early-return let-else in filtered_read.rs nicely reduces nesting.

LGTM.

@Xuanwo Xuanwo changed the title style: split unrelated clippy cleanups from blob fix chore: split unrelated clippy cleanups from blob fix Mar 12, 2026
@Xuanwo Xuanwo changed the title chore: split unrelated clippy cleanups from blob fix chore: clippy cleanups Mar 12, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 85.33333% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance/src/io/exec/filtered_read.rs 82.92% 2 Missing and 5 partials ⚠️
rust/lance/src/dataset/fragment.rs 60.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Xuanwo Xuanwo merged commit 31cd8d3 into main Mar 12, 2026
34 of 36 checks passed
@Xuanwo Xuanwo deleted the xuanwo/fix-clippy-cleanups branch March 12, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants