test: stabilize distributed IVF grouped build query test#6281
Merged
Xuanwo merged 1 commit intolance-format:mainfrom Mar 24, 2026
Merged
test: stabilize distributed IVF grouped build query test#6281Xuanwo merged 1 commit intolance-format:mainfrom
Xuanwo merged 1 commit intolance-format:mainfrom
Conversation
Contributor
ReviewLGTM. Minimal, correct fix — applies the same No issues. |
myandpr
changed the title
myandpr
changed the title
myandpr
changed the title
Contributor
Author
|
Hi @Xuanwo , could you take another look this PR when you have a chance? This is a small follow-up to #6268. That CI failure also pointed to the same kind of flaky distributed IVF test behavior: https://github.com/lance-format/lance/actions/runs/23499541618/job/68390439921?pr=6263 Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
westonpace
pushed a commit
that referenced
this pull request
Mar 24, 2026
wjones127
pushed a commit
to wjones127/lance
that referenced
this pull request
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6268.
This applies the same stabilization to the grouped distributed IVF query test in
rust/lance/src/index/vector/ivf/v2.rs.Like the earlier flaky test, it was asserting exact Top-K
_rowidequality while still using the default probing behavior. This change setsminimum_nprobes(TWO_FRAG_NUM_PARTITIONS)before making that exact row-id comparison.Recent related CI failure:
https://github.com/lance-format/lance/actions/runs/23499541618/job/68390439921?pr=6263