feat(python): add storage_options to IvfModel and PqModel save/load#6312
Merged
Xuanwo merged 1 commit intolance-format:mainfrom Mar 27, 2026
Merged
feat(python): add storage_options to IvfModel and PqModel save/load#6312Xuanwo merged 1 commit intolance-format:mainfrom
Xuanwo merged 1 commit intolance-format:mainfrom
Conversation
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6311
What
Add an optional
storage_optionskeyword argument toIvfModel.save(),IvfModel.load(),PqModel.save(), andPqModel.load(), and forward it to the underlyingLanceFileWriter/LanceFileReader.Why
These methods accept cloud storage URIs (e.g.
s3://,gs://) but previously had no way to pass credentials or backend-specific configuration. Users were forced to rely on environment variables for authentication, which breaks down when dealing with multiple storage backends that require different credentials.Both
LanceFileWriterandLanceFileReaderalready supportstorage_options— this change simply threads the parameter through.Change Summary
python/python/lance/indices/ivf.py: Addstorage_optionsparameter toIvfModel.save()andIvfModel.load(), forward toLanceFileWriter/LanceFileReader.python/python/lance/indices/pq.py: Same change forPqModel.save()andPqModel.load().Usage