feat: add configurable blob v2 pack file size#6508
Merged
Xuanwo merged 2 commits intolance-format:mainfrom Apr 14, 2026
Merged
Conversation
Add blob_max_pack_file_bytes to WriteParams, allowing users to override the default 1 GiB maximum pack (.blob) sidecar file size. Exposed in Rust, Python, and Java APIs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Xuanwo
reviewed
Apr 14, 2026
Collaborator
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
| "target_bases": target_bases, | ||
| "external_blob_mode": external_blob_mode, | ||
| "allow_external_blob_outside_bases": allow_external_blob_outside_bases, | ||
| "blob_max_pack_file_bytes": blob_max_pack_file_bytes, |
Collaborator
There was a problem hiding this comment.
How about using options like blob_pack_file_size_threshold? Align better with existing naming.
Contributor
Author
There was a problem hiding this comment.
No problem, I updated it!
| &initial_bases, | ||
| &target_bases, | ||
| &JObject::null(), // allow_external_blob_outside_bases not used for Dataset.write() | ||
| &JObject::null(), // blob_max_pack_file_bytes not used for Dataset.write() |
Contributor
Author
There was a problem hiding this comment.
Looks like we were not passing the allow_external_blob_outside_bases option either. So I updated this to plumb both of them through so this is available using Dataset.write and not just through the fragment creation APIs in Java.
…hrough Dataset.write() Rename blob_max_pack_file_bytes to blob_pack_file_size_threshold across Rust, Python, and Java. Wire both allow_external_blob_outside_bases and blob_pack_file_size_threshold through the Java Dataset.write() JNI path, which previously hardcoded them to null/defaults. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Xuanwo
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blob_max_pack_file_bytestoWriteParams, allowing users to override the default 1 GiB maximum pack (.blob) sidecar file sizeWriteParams->WriterGenerator->WriterOptions->BlobPreprocessor->PackWriterwrite_dataset) and Java (WriteParams.Builder) bindingsTest plan
cargo test -p lance blob)lanceandlance-jnicratesblob_max_pack_file_byteskwarg./mvnw compile🤖 Generated with Claude Code