Skip to content

fix(namespace): serialize manifest mutations#6525

Merged
Xuanwo merged 1 commit intomainfrom
xuanwo/fix-manifest-mutation-contention
Apr 15, 2026
Merged

fix(namespace): serialize manifest mutations#6525
Xuanwo merged 1 commit intomainfrom
xuanwo/fix-manifest-mutation-contention

Conversation

@Xuanwo
Copy link
Copy Markdown
Collaborator

@Xuanwo Xuanwo commented Apr 15, 2026

This fixes the directory namespace CI failure where single-instance concurrent create/drop operations on __manifest could time out with TooMuchWriteContention, especially in the Windows build.

Manifest mutations are now serialized within a single ManifestNamespace instance so concurrent operations stop racing on stale in-memory snapshots, and inline manifest maintenance now defers compaction/index merges until the table has accumulated enough fragments.

Context: https://github.com/lance-format/lance/actions/runs/24439767878/job/71401857043

@github-actions github-actions Bot added the bug Something isn't working label Apr 15, 2026
@Xuanwo Xuanwo marked this pull request as ready for review April 15, 2026 07:43
@Xuanwo Xuanwo merged commit 4ea9166 into main Apr 15, 2026
30 checks passed
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance-namespace-impls/src/dir/manifest.rs 72.72% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Xuanwo Xuanwo deleted the xuanwo/fix-manifest-mutation-contention branch April 15, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants