fix: pin lance-namespace<0.7 in pylance dependencies#6604
Open
LuciferYang wants to merge 1 commit intolance-format:mainfrom
Open
fix: pin lance-namespace<0.7 in pylance dependencies#6604LuciferYang wants to merge 1 commit intolance-format:mainfrom
LuciferYang wants to merge 1 commit intolance-format:mainfrom
Conversation
lance-namespace 0.7.0 removed CreateEmptyTableRequest/CreateEmptyTableResponse symbols. Released pylance wheels (e.g. 2.0.1, 4.0.0b1) import these symbols, causing ImportError when users pip install an old pylance version and resolve lance-namespace>=0.7. Add an upper bound to prevent this breakage. Ref: lance-format#6597 (comment)
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
Author
|
cc @jackye1995 FYI |
Contributor
|
I already created a patch in 4.0.0, will publish 4.0.1 with it: #6603. The API is already depreacted for one release, so the plan is to fully remove it in 5.0.0+ |
Contributor
|
For the main branch, I am raising a PR for bumping the lance-namespace verson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<0.7tolance-namespacedependency inpython/pyproject.tomlto prevent released pylance wheels from breaking whenlance-namespace>=0.7is installedRoot cause
lance-namespace 0.7.0removedCreateEmptyTableRequest/CreateEmptyTableResponsesymbols. Released pylance wheels (e.g.2.0.1,4.0.0b1) still import these symbols inlance/namespace.py, causingImportErrorwhen userspip installan old pylance version and pip resolveslance-namespace>=0.7.PR #6597 fixed this for CI compat tests by pinning in
venv_manager.py, but real users installing from PyPI are still affected.Ref: #6597 (comment)
Test plan
lance-namespace<0.7and avoid ImportError