Skip to content

Conversation

@keenborder786
Copy link
Contributor

@github-actions github-actions bot added integration PR made that is related to a provider partner package integration groq `langchain-groq` package issues & PRs ollama `langchain-ollama` package issues & PRs infra PRs made that include chores, devops, repo meta changes labels Dec 2, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 2, 2025

CodSpeed Performance Report

Merging #34167 will not alter performance

Comparing keenborder786:filtering_extra_parameter (de477e8) with master (05ba853)

Summary

✅ 1 untouched
⏩ 33 skipped1

Footnotes

  1. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@ccurme ccurme self-assigned this Dec 5, 2025
@keenborder786
Copy link
Contributor Author

@ccurme is this looking good?

Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding Ollama (and possibly Groq): we should add handling for response_format, similar to what's done here for Anthropic:

if "response_format" in payload:
# response_format present when using agents.create_agent's ProviderStrategy
# ---
# ProviderStrategy converts to OpenAI-style format, which passes kwargs to
# ChatAnthropic, ending up in our payload
response_format = payload.pop("response_format")
if (
isinstance(response_format, dict)
and response_format.get("type") == "json_schema"
and "schema" in response_format.get("json_schema", {})
):
response_format = cast(dict, response_format["json_schema"]["schema"])
# Convert OpenAI-style response_format to Anthropic's output_format
payload["output_format"] = _convert_to_anthropic_output_format(
response_format
)

@ccurme
Copy link
Collaborator

ccurme commented Dec 12, 2025

Thanks!

@ccurme ccurme merged commit 0871075 into langchain-ai:master Dec 12, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

groq `langchain-groq` package issues & PRs infra PRs made that include chores, devops, repo meta changes integration PR made that is related to a provider partner package integration ollama `langchain-ollama` package issues & PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Groq openai/gpt-oss-120b model incompatible with structured output (create_agent, ChatGroq.with_structured_output)

2 participants