fix: Update dependency versions - pyproject.toml#10028
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughDependency specifications were revised across multiple pyproject.toml files to introduce upper bounds and tighten ranges. Several starter project JSON templates adjusted specific dependency versions (cryptography, scrapegraph_py, apify_client). No application code, control flow, or public API changes were made. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (7 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Fantastic addition @HimavarshaVS . Agree with @jordanrfrazier 's comments, once those are in i think this can be approved. The version updates have been a long time coming, and pinning versions vs using Looks great! |
b7c0a22 to
a1b6106
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/backend/base/langflow/initial_setup/starter_projects/Knowledge Ingestion.json (1)
749-749: Approve downgrade to 42.0.8 as the latest 42.x release with all high/moderate patches included. Note that the low-severity “Vulnerable OpenSSL in wheels” advisory (published 2025-02-11) affects both 42.x and 43.x and is only fixed in 44.0.1—upgrade to ≥44.0.1 and adjust your bounds if you need that specific patch.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
src/backend/base/uv.lockis excluded by!**/*.lockuv.lockis excluded by!**/*.lock
📒 Files selected for processing (7)
pyproject.toml(4 hunks)src/backend/base/langflow/initial_setup/starter_projects/Knowledge Ingestion.json(1 hunks)src/backend/base/langflow/initial_setup/starter_projects/Knowledge Retrieval.json(1 hunks)src/backend/base/langflow/initial_setup/starter_projects/Search agent.json(1 hunks)src/backend/base/langflow/initial_setup/starter_projects/Social Media Agent.json(2 hunks)src/backend/base/pyproject.toml(4 hunks)src/lfx/pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test-starter-projects
🔇 Additional comments (7)
src/lfx/pyproject.toml (1)
11-41: LGTM! Dependency upper bounds added appropriately.The addition of upper bounds to prevent unbounded major version upgrades is a good practice that:
- Improves build reproducibility
- Prevents breaking changes from unexpected major version bumps
- Aligns with the PR objective to maintain stability
All bounds follow semantic versioning conventions (blocking next major version), which is the recommended approach.
src/backend/base/pyproject.toml (4)
55-55: Cryptography upper bound reduction explains JSON downgrades.The cryptography upper bound was reduced from
<44.0.0to<43.0.0. This explains the version downgrades to 42.0.8 in the starter project JSON files (Knowledge Ingestion.json and Knowledge Retrieval.json).Ensure this tightened constraint is compatible with all dependencies that require cryptography, and that version 42.0.8 has no known security vulnerabilities.
See the verification script in the review comment for Knowledge Ingestion.json (line 749) to check cryptography security status.
79-93: LGTM! Main dependency upper bounds added appropriately.The addition of upper bounds to validators, networkx, json-repair, and other dependencies follows best practices and aligns with the PR objectives.
98-132: LGTM! Dev dependency upper bounds added appropriately.The systematic addition of upper bounds to all dev dependencies improves build reproducibility and prevents breaking changes during development.
25-25: Relax or document gunicorn upper bound change. 23.0.0 (released 2024-08-10) includes only minor docs fixes, a new worker_class parameter, deadlock/security fixes, and no breaking changes (github.com). If excluding 23.x wasn’t intentional, revert to<24.0.0; otherwise, document why 23.x must be blocked.pyproject.toml (2)
32-133: LGTM! Comprehensive dependency upper bounds added.The systematic addition of upper bounds across runtime dependencies follows the PR objectives and incorporates feedback from previous review comments. Key improvements:
- Replaces exact version pins with flexible ranges (e.g.,
types-cachetools>=5.5.0.20240820,<6.0.0)- Adds upper bounds to langchain ecosystem packages (e.g.,
langchain-astradb>=0.6.1,<1.0.0)- Consolidates per-Python-version constraints into universal upper-bounded ranges where appropriate
- Increases datasets upper bound to
<4.0.0as discussed in previous review commentsThis approach improves dependency resolution speed (as noted by reviewer erichare regarding "uv") while maintaining compatibility guarantees.
Based on past review comments addressing the approach with jordanrfrazier.
136-183: LGTM! Dev dependency upper bounds added consistently.The addition of upper bounds to all dev dependencies mirrors the approach taken for runtime dependencies and ensures consistent dependency management across the project.
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (47.25%) is below the target coverage (55.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #10028 +/- ##
==========================================
+ Coverage 24.12% 24.21% +0.09%
==========================================
Files 1091 1091
Lines 40014 40013 -1
Branches 5543 5542 -1
==========================================
+ Hits 9653 9691 +38
+ Misses 30190 30151 -39
Partials 171 171
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
f918249 to
d577a0a
Compare
|



Description
This PR updates the dependency version bounds in pyproject.toml to ensure:
Changes
< next_major.0.0where applicable.- src/backend/base/langflow/initial_setup/starter_projects/Knowledge Ingestion.json
- src/backend/base/langflow/initial_setup/starter_projects/Knowledge Retrieval.json
Testing
Able to successfully launch langflow

Summary by CodeRabbit