Skip to content

fix: Backport macOS specific ver reqs#10099

Merged
erichare merged 1 commit into
mainfrom
fix-docling-intel-mac
Oct 3, 2025
Merged

fix: Backport macOS specific ver reqs#10099
erichare merged 1 commit into
mainfrom
fix-docling-intel-mac

Conversation

@erichare
Copy link
Copy Markdown
Collaborator

@erichare erichare commented Oct 2, 2025

This pull request updates the dependency configuration in pyproject.toml to improve compatibility with different platforms, especially addressing issues for macOS on x86_64 architecture. The main changes involve conditional dependencies for certain packages and the introduction of a new core package.

Dependency updates and platform-specific adjustments:

  • Replaced the unconditional docling dependency with docling-core for all platforms, and made docling conditional so it is only installed on platforms other than macOS x86_64.
  • Made easyocr and opencv-python dependencies conditional so they are not installed on macOS x86_64, improving compatibility for that platform.

Minor changes:

  • Added a trailing comma to the python-pptx override dependency for consistency.

Summary by CodeRabbit

  • Bug Fixes

    • Improved cross-platform installation reliability, especially on macOS (Intel), by refining platform-specific dependency rules.
  • Chores

    • Updated core document-processing dependency and aligned related libraries.
    • Applied platform-conditional installs to reduce download size and avoid unnecessary packages on macOS (Intel).
    • Maintained existing dependencies without functional changes.
    • Minor formatting tidy-up in dependency configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 2, 2025

Walkthrough

Updates dependency declarations in pyproject.toml: replaces docling with docling-core and restores platform-conditional markers for docling, easyocr, and opencv-python. Keeps other dependencies unchanged. Adds a trailing comma in the python-pptx override section.

Changes

Cohort / File(s) Change Summary
Dependency updates
pyproject.toml
Replaced docling with docling-core (>=2.36.1,<3.0.0). Restored platform markers for docling, easyocr, opencv-python to exclude macOS x86_64. Retained existing dependencies. Minor formatting: added trailing comma in override-dependencies for python-pptx.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

bug, size:M

Suggested reviewers

  • jordanrfrazier

Pre-merge checks and finishing touches

❌ Failed checks (1 error, 3 inconclusive)
Check name Status Explanation Resolution
Test Coverage For New Implementations ❌ Error The PR modifies only dependency declarations without touching any test files. Because it is a bug fix (noted by the “fix:” prefix) and the custom check requires regression tests for bug fixes, the absence of any new or updated tests means the requirement is not met. Add regression tests that verify the dependency conditions on macOS x86_64, for example by simulating installation or import failures on that platform, to cover the backported version requirements.
Test Quality And Coverage ❓ Inconclusive
Test File Naming And Structure ❓ Inconclusive
Excessive Mock Usage Warning ❓ Inconclusive
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit's high-level summary is enabled.
Title Check ✅ Passed The title succinctly captures the primary change—backporting macOS-specific version requirements—and clearly relates to the conditional dependency updates for macOS x86_64. It is concise and specific without using vague terms.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-docling-intel-mac

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aeb76cf and 0d94289.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: Lint Backend / Run Mypy (3.13)
  • GitHub Check: Lint Backend / Run Mypy (3.11)
  • GitHub Check: Lint Backend / Run Mypy (3.12)
  • GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 5
  • GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 3
  • GitHub Check: Run Backend Tests / Integration Tests - Python 3.10
  • GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 4
  • GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 2
  • GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 1
  • GitHub Check: Test Starter Templates

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the bug Something isn't working label Oct 2, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 2, 2025

@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Oct 2, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 24.21%. Comparing base (485358c) to head (0d94289).
⚠️ Report is 2 commits behind head on main.

❌ Your project status has failed because the head coverage (47.17%) is below the target coverage (55.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10099      +/-   ##
==========================================
+ Coverage   24.19%   24.21%   +0.01%     
==========================================
  Files        1091     1091              
  Lines       40042    40059      +17     
  Branches     5544     5541       -3     
==========================================
+ Hits         9688     9700      +12     
- Misses      30183    30188       +5     
  Partials      171      171              
Flag Coverage Δ
backend 47.17% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the lgtm This PR has been approved by a maintainer label Oct 3, 2025
@erichare erichare added this pull request to the merge queue Oct 3, 2025
Merged via the queue into main with commit 58efe80 Oct 3, 2025
31 of 32 checks passed
@erichare erichare deleted the fix-docling-intel-mac branch October 3, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants