Skip to content

fix: lazy load settings service; fix env init order#10142

Merged
jordanrfrazier merged 16 commits into
release-1.6.4from
lazy-load-settings-service
Oct 7, 2025
Merged

fix: lazy load settings service; fix env init order#10142
jordanrfrazier merged 16 commits into
release-1.6.4from
lazy-load-settings-service

Conversation

@jordanrfrazier
Copy link
Copy Markdown
Collaborator

Enforces that the setting service is not initialized before the env file is loaded.

This ensures that we aren't loading the settings without picking up the correct environment variables, even if the user sets a custom env file path.

@jordanrfrazier jordanrfrazier changed the base branch from main to release-1.6.4 October 6, 2025 19:50
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 6, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch lazy-load-settings-service

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Oct 6, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Oct 6, 2025
Copy link
Copy Markdown
Collaborator

@HimavarshaVS HimavarshaVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions Bot added lgtm This PR has been approved by a maintainer bug Something isn't working and removed bug Something isn't working labels Oct 6, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Oct 6, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Oct 6, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Oct 6, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Oct 7, 2025
@github-actions github-actions Bot added the bug Something isn't working label Oct 7, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Oct 7, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Oct 7, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Oct 7, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 32 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-1.6.4@6ee3d50). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...rc/backend/base/langflow/api/v1/knowledge_bases.py 15.38% 11 Missing ⚠️
...e/langflow/components/knowledge_bases/ingestion.py 50.00% 6 Missing ⚠️
...e/langflow/components/knowledge_bases/retrieval.py 45.45% 6 Missing ⚠️
src/backend/base/langflow/__main__.py 25.00% 3 Missing ⚠️
src/backend/base/langflow/api/v1/mcp_projects.py 0.00% 2 Missing ⚠️
src/backend/base/langflow/base/mcp/util.py 86.66% 2 Missing ⚠️
src/backend/base/langflow/graph/edge/base.py 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-1.6.4   #10142   +/-   ##
================================================
  Coverage                 ?   35.84%           
================================================
  Files                    ?     1220           
  Lines                    ?    58229           
  Branches                 ?     5530           
================================================
  Hits                     ?    20873           
  Misses                   ?    37195           
  Partials                 ?      161           
Flag Coverage Δ
backend 55.78% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...se/langflow/components/input_output/chat_output.py 88.31% <100.00%> (ø)
src/backend/base/langflow/schema/dataframe.py 91.48% <100.00%> (ø)
src/backend/base/langflow/services/deps.py 91.30% <100.00%> (ø)
src/backend/base/langflow/api/v1/mcp_projects.py 24.11% <0.00%> (ø)
src/backend/base/langflow/base/mcp/util.py 57.00% <86.66%> (ø)
src/backend/base/langflow/graph/edge/base.py 51.97% <0.00%> (ø)
src/backend/base/langflow/__main__.py 54.50% <25.00%> (ø)
...e/langflow/components/knowledge_bases/ingestion.py 74.91% <50.00%> (ø)
...e/langflow/components/knowledge_bases/retrieval.py 73.22% <45.45%> (ø)
...rc/backend/base/langflow/api/v1/knowledge_bases.py 16.34% <15.38%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jordanrfrazier jordanrfrazier enabled auto-merge (squash) October 7, 2025 02:51
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Oct 7, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Oct 7, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Oct 7, 2025
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 7, 2025

@jordanrfrazier jordanrfrazier merged commit 7125c60 into release-1.6.4 Oct 7, 2025
74 checks passed
@jordanrfrazier jordanrfrazier deleted the lazy-load-settings-service branch October 7, 2025 03:56
HimavarshaVS pushed a commit that referenced this pull request Oct 16, 2025
* Ensure settings services are lazy loaded; fixes settings init order

* Remove dupe tests

* remove useless test

* [autofix.ci] apply automated fixes

* Ruff

* [autofix.ci] apply automated fixes

* mypy

* Fix test reference

* ruff fixes

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* ruff + starter projects

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
github-merge-queue Bot pushed a commit that referenced this pull request Oct 21, 2025
* fix: lazy load settings service; fix env init order (#10142)

* Ensure settings services are lazy loaded; fixes settings init order

* Remove dupe tests

* remove useless test

* [autofix.ci] apply automated fixes

* Ruff

* [autofix.ci] apply automated fixes

* mypy

* Fix test reference

* ruff fixes

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* ruff + starter projects

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

* chore: update component index

* fix import errors

* [autofix.ci] apply automated fixes

* chore: update component index

* fix service manager imports in  main

* chore: update component index

* fix lfx service manager

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* chore: update component index

* chore: update component index

* chore: update component index

* chore: update component index

* fix tests

* [autofix.ci] apply automated fixes

* chore: update component index

* chore: update component index

* chore: update component index

* fix ruff errors

* [autofix.ci] apply automated fixes

* fix test_mcp_util

* [autofix.ci] apply automated fixes

* chore: update component index

* chore: update component index

* [autofix.ci] apply automated fixes

* build component index

---------

Co-authored-by: Jordan Frazier <122494242+jordanrfrazier@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
korenLazar pushed a commit to kiran-kate/langflow that referenced this pull request Nov 13, 2025
… (langflow-ai#10307)

* fix: lazy load settings service; fix env init order (langflow-ai#10142)

* Ensure settings services are lazy loaded; fixes settings init order

* Remove dupe tests

* remove useless test

* [autofix.ci] apply automated fixes

* Ruff

* [autofix.ci] apply automated fixes

* mypy

* Fix test reference

* ruff fixes

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* ruff + starter projects

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

* chore: update component index

* fix import errors

* [autofix.ci] apply automated fixes

* chore: update component index

* fix service manager imports in  main

* chore: update component index

* fix lfx service manager

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* chore: update component index

* chore: update component index

* chore: update component index

* chore: update component index

* fix tests

* [autofix.ci] apply automated fixes

* chore: update component index

* chore: update component index

* chore: update component index

* fix ruff errors

* [autofix.ci] apply automated fixes

* fix test_mcp_util

* [autofix.ci] apply automated fixes

* chore: update component index

* chore: update component index

* [autofix.ci] apply automated fixes

* build component index

---------

Co-authored-by: Jordan Frazier <122494242+jordanrfrazier@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants