fix: Update Vector Store RAG connections#10217
Conversation
WalkthroughRenames numerous node and edge IDs in the Vector Store RAG starter project JSON, updates all references accordingly, adds external_options and related UI metadata to inputs/templates, adjusts visibility/defaults, and updates metadata timestamps and viewport. No executable logic changes; all updates are within the starter project configuration. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 error, 2 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/backend/base/langflow/initial_setup/starter_projects/Vector Store RAG.json (2)
759-767: Fix Split Text selected_output mismatchOutputs expose name "dataframe", but node.selected_output is "chunks" (display name). Use the output name to avoid UI/default-selection bugs.
Apply:
- "selected_output": "chunks", + "selected_output": "dataframe",Also applies to: 915-916
1-5036: Fix SplitText selected_output to match an outputs[].nameEdges validated OK; node SplitText-4s7Dt has selected_output "chunks" which doesn't match any outputs[].name (the output name is "dataframe") — update selected_output to "dataframe" in src/backend/base/langflow/initial_setup/starter_projects/Vector Store RAG.json (node id: SplitText-4s7Dt).
🧹 Nitpick comments (2)
src/backend/base/langflow/initial_setup/starter_projects/Vector Store RAG.json (2)
26-31: Normalize edge id schema (consistency/interop)Edge ids mix "reactflow__edge-" and "xy-edge__" prefixes. Not functionally wrong, but inconsistent ids can surprise tooling relying on a single scheme (dedup, selection). Consider standardizing.
Also applies to: 257-263, 284-288
3889-3894: Consider defaulting AstraDB.embedding_model to hiddenTemplate sets embedding_model.show = true, while runtime logic toggles based on provider/autodetect. Defaulting to false prevents brief UI flash/misleading state before build_config runs.
- "show": true, + "show": false,Also applies to: 4702-4707
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/backend/base/langflow/initial_setup/starter_projects/Vector Store RAG.json(69 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 2
- GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 3
- GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 4
- GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 5
- GitHub Check: Run Backend Tests / Integration Tests - Python 3.10
- GitHub Check: Run Backend Tests / Unit Tests - Python 3.10 - Group 1
- GitHub Check: Lint Backend / Run Mypy (3.13)
- GitHub Check: Run Frontend Tests / Determine Test Suites and Shard Distribution
- GitHub Check: Test Starter Templates
- GitHub Check: Optimize new Python code in this PR
- GitHub Check: test-starter-projects
🔇 Additional comments (2)
src/backend/base/langflow/initial_setup/starter_projects/Vector Store RAG.json (2)
236-263: Good: explicit Embeddings → Vector Store links addedBoth ingestion and retrieval Astra DB nodes now receive embedding_model via edges from their OpenAIEmbeddings nodes. This clarifies model flow and removes ambiguity.
Also applies to: 265-289
3535-3549: external_options additions: confirm UI handling/back-compatAdding external_options to DropdownInput is fine, but verify:
- Current UI consumes/ignores it safely.
- Older LF versions won’t choke on the field if users import this starter there.
Also applies to: 4348-4362
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (48.71%) is below the target coverage (55.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #10217 +/- ##
=======================================
Coverage 24.76% 24.76%
=======================================
Files 1090 1090
Lines 40108 40108
Branches 5550 5550
=======================================
Hits 9934 9934
Misses 30003 30003
Partials 171 171
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|



This pull request updates the Vector Store RAG template to ensure that all connections are maintained, particularly the Embedding Model input to Astra DB.
Key changes:
Flow structure and connections:
OpenAIEmbeddingsnodes to their respectiveAstraDBvector store nodes, clarifying how embedding models are used in both the data loading and retrieval flows.Node and documentation updates:
Summary by CodeRabbit
New Features
Style
Chores