Skip to content

docs: Update memory and storage configuration guide#10318

Closed
Cristhianzl wants to merge 1 commit into
mainfrom
cz/fix-doc-db-loc
Closed

docs: Update memory and storage configuration guide#10318
Cristhianzl wants to merge 1 commit into
mainfrom
cz/fix-doc-db-loc

Conversation

@Cristhianzl
Copy link
Copy Markdown
Member

@Cristhianzl Cristhianzl commented Oct 17, 2025

This pull request updates the documentation for Langflow's memory and storage configuration. The main focus is on clarifying default storage paths, environment variable usage, and improving formatting for better readability. The most important changes are grouped below:

Storage Path Updates:

  • Updated the default Windows storage path for Langflow Desktop to C:\Users\<name>\AppData\Roaming\com.LangflowDesktop\data\database.db for accuracy.

Formatting and Readability Improvements:

  • Fixed formatting of environment variable descriptions to use consistent markdown lists and tables, improving readability and clarity in sections for database connection settings and cache options. [1] [2]

Component and Usage Documentation:

  • Clarified explanations for Agent, Message History, and third-party chat memory components, and improved the formatting of the "See also" section for easier navigation.

Summary by CodeRabbit

  • Documentation
    • Updated storage path information for Langflow Desktop on Windows database configuration
    • Improved formatting and readability of memory configuration documentation sections, including bullet points, code blocks, and table formatting
    • Enhanced clarity through minor textual adjustments across configuration, external database, and cache memory sections while preserving all technical content

…to correct directory structure

📝 (memory.mdx): Improve formatting and consistency in storage path descriptions for different environments
📝 (memory.mdx): Clarify instructions for configuring external PostgreSQL database for Langflow storage
📝 (memory.mdx): Enhance readability and organization of database connection pool settings information
📝 (memory.mdx): Update cache memory configuration variables table for clarity and consistency
📝 (memory.mdx): Refactor and reorganize information on storing chat memory for better understanding and readability
@Cristhianzl Cristhianzl requested a review from mendonk October 17, 2025 13:40
@Cristhianzl Cristhianzl self-assigned this Oct 17, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 17, 2025

Walkthrough

Documentation update to memory configuration guide covering Langflow Desktop storage path changes on Windows (com.Langflow to com.LangflowDesktop), along with formatting and minor textual rewording adjustments.

Changes

Cohort / File(s) Change Summary
Memory Documentation
docs/docs/Develop/memory.mdx
Updated Windows storage path for Langflow Desktop database; reflowed and re-indented sections; minor textual rewording and spacing adjustments to Config directory, External PostgreSQL memory, cache memory, store chat memory, and See also sections

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • #9122 — Updates memory documentation's database and storage paths for consistency.
  • #9751 — Broader memory documentation refresh affecting the same file.
  • #10089 — Updates documentation to reflect Langflow Desktop path rename (com.Langflow → com.LangflowDesktop).

Suggested labels

documentation, lgtm

Suggested reviewers

  • mendonk
  • italojohnny
  • aimurphy

Pre-merge checks and finishing touches

❌ Failed checks (2 inconclusive)
Check name Status Explanation Resolution
Test File Naming And Structure ❓ Inconclusive The custom check is designed to verify test file naming and structure patterns, including backend tests (test_.py), frontend tests (.test.ts or .test.tsx), integration tests, and proper test organization. However, the PR modification confirmed by the shell script results contains only a single documentation file: docs/docs/Develop/memory.mdx. This PR introduces no test files whatsoever—neither backend test files following the test_.py pattern, frontend test files using .test.ts/.test.tsx extensions, nor integration test files. Therefore, the check cannot be applied or evaluated against the specified criteria.
Excessive Mock Usage Warning ❓ Inconclusive The custom check for "Excessive Mock Usage Warning" is designed to review test files for excessive use of mocks that may indicate poor test design. However, this PR (10318) exclusively modifies documentation files (specifically docs/docs/Develop/memory.mdx) to update memory and storage configuration guides. The PR contains no test files, test code, or any code changes whatsoever—only formatting improvements, typo fixes, and documentation updates related to Langflow's desktop database storage paths and environment variable descriptions.
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "docs: Update memory and storage configuration guide" is directly aligned with the changeset. The changes involve updating documentation for Langflow's memory and storage configuration, specifically correcting storage paths for Langflow Desktop on Windows, improving formatting consistency across sections, and clarifying component documentation. The title accurately captures the primary focus of these updates and uses the "docs:" prefix to appropriately indicate these are documentation-only changes. The title is concise, specific, and clearly communicates the main purpose without vague or misleading language.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Test Coverage For New Implementations ✅ Passed The PR contains only one file change: docs/docs/Develop/memory.mdx, which is a documentation file. The git diff confirms no test files were added or modified in this PR. Since the PR consists exclusively of documentation updates (correcting storage paths, reformatting sections, and rewording explanations) with no code changes, new components, functionality additions, or bug fixes to the codebase, the test coverage criteria specified in the custom check do not apply. Documentation-only updates do not require corresponding test files, as they contain no executable code or behavioral changes that would necessitate testing.
Test Quality And Coverage ✅ Passed This pull request is a documentation-only change affecting three documentation files: docs/docs/Develop/memory.mdx, docs/docs/Components/bundles-cometapi.mdx, and docs/sidebars.js. The changes consist of correcting the Windows storage path for Langflow Desktop, fixing a typo ("A a" to "A"), and reformatting sections for improved readability. Per the PR summary, there are no changes to public/exported entity signatures or code behavior—changes are confined to documentation formatting and wording. No new code implementations, functionality, or tests are being introduced in this PR.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cz/fix-doc-db-loc

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Oct 17, 2025
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 17, 2025

Build successful! ✅
Deploying docs draft.
Deploy successful! View draft

@github-actions github-actions Bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Oct 17, 2025
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
docs/docs/Develop/memory.mdx (2)

85-86: Consider shortening wordy phrasing.

The phrase "in excess of" can be more concisely expressed as "beyond" or "over". This improves readability without changing meaning.

- `max_overflow`: Maximum number of connections that can be created in excess of `pool_size` if needed. Default: 30.
+ `max_overflow`: Maximum number of connections that can be created beyond `pool_size` if needed. Default: 30.

171-173: Reduce phrasing repetition in the third-party chat memory component description.

Lines 171–173 repeat "if you want to use" and "database" in close proximity, reducing clarity. Consider restructuring to improve variety and flow.

- **Third-party chat memory components**: Use one of these components only if you need to store or retrieve chat memories from a dedicated external chat memory database.
-   Typically, this is necessary only if you have specific storage needs that aren't met by Langflow storage.
-   For example, if you want to manage chat memory data by directly working with the database, or if you want to use a different database than the default Langflow storage.
+ **Third-party chat memory components**: Use one of these components only if you need to store or retrieve chat memories from a dedicated external chat memory database.
+   Typically, this is necessary only if you have specific storage needs that aren't met by Langflow storage.
+   For example, use these components if you need to directly manage chat memory data or store memories in an alternative database system.
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5c4b8be and da5c7b5.

📒 Files selected for processing (1)
  • docs/docs/Develop/memory.mdx (4 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
docs/**/*.{md,mdx}

📄 CodeRabbit inference engine (.cursor/rules/docs_development.mdc)

docs/**/*.{md,mdx}: All Markdown/MDX pages must start with front matter including at least title and description; include sidebar_position for docs pages when applicable
Code blocks must specify a language and may include a title (```lang title="…")
Use sentence case for headings and keep paragraphs short and scannable
Write in second person, present tense, with a professional but approachable tone
Use inline code with backticks for code terms; use bold for UI elements and italics for emphasis; keep lists in parallel structure
Ensure internal links are functional and navigation works (update cross-references as needed)
Verify all code examples in docs and blog actually run as shown
Use correct terminology capitalization: Langflow, Component, Flow, API, JSON
Reference images with absolute paths under /img/... and provide descriptive alt text

Files:

  • docs/docs/Develop/memory.mdx
docs/docs/**/*.{md,mdx}

📄 CodeRabbit inference engine (.cursor/rules/docs_development.mdc)

Use Docusaurus admonitions (:::+tip|warning|danger) instead of custom callouts in docs pages

Files:

  • docs/docs/Develop/memory.mdx
🪛 LanguageTool
docs/docs/Develop/memory.mdx

[style] ~86-~86: ‘in excess of’ might be wordy. Consider a shorter alternative.
Context: ...mber of connections that can be created in excess of pool_size if needed. Default: 30. -...

(EN_WORDINESS_PREMIUM_IN_EXCESS_OF)


[style] ~173-~173: You have already used this phrasing in nearby sentences. Consider replacing it to add variety to your writing.
Context: ...ly working with the database, or if you want to use a different database than the defau...

(REP_WANT_TO_VB)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Test Docs Build / Test Docs Build
  • GitHub Check: build-and-deploy
🔇 Additional comments (1)
docs/docs/Develop/memory.mdx (1)

1-4: Verify front matter completeness per documentation guidelines.

The coding guidelines require front matter with at least title and description, plus sidebar_position for docs pages. The provided front matter includes title and slug, but description and sidebar_position are not shown. Please confirm these are present or add them if missing.

- `LANGFLOW_DB_CONNECT_TIMEOUT`: The number of seconds to wait before giving up on a lock to be released or establishing a connection to the database. This may be separate from the `pool_timeout` in `LANGFLOW_DB_CONNECTION_SETTINGS`. Default: 30.

* `LANGFLOW_DB_CONNECTION_SETTINGS`: A a JSON dictionary containing the following database connection pool settings:
- `LANGFLOW_DB_CONNECTION_SETTINGS`: A a JSON dictionary containing the following database connection pool settings:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix typo in environment variable description.

Line 83 contains a duplicate article: "A a JSON dictionary" should be "A JSON dictionary".

- `LANGFLOW_DB_CONNECTION_SETTINGS`: A a JSON dictionary containing the following database connection pool settings:
+ `LANGFLOW_DB_CONNECTION_SETTINGS`: A JSON dictionary containing the following database connection pool settings:
🤖 Prompt for AI Agents
In docs/docs/Develop/memory.mdx around line 83, fix the typo in the environment
variable description by removing the duplicate article: change "A a JSON
dictionary" to "A JSON dictionary" so the sentence reads correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant