⚡️ Speed up method ModelProviderCredentialRequest.validate_provider by 32% in PR #10351 (model-provider-keys-v2)

[codeflash-ai]

⚡️ This pull request contains optimizations for PR #10351

If you approve this dependent PR, these changes will be merged into the original PR branch model-provider-keys-v2.

This PR will be automatically closed if the original PR is merged.

---

📄 32% (0.32x) speedup for ModelProviderCredentialRequest.validate_provider in src/backend/base/langflow/api/v1/model_provider_credentials.py

⏱️ Runtime : 20.8 microseconds → 15.8 microseconds (best of 37 runs)

📝 Explanation and details

The optimization achieves a 31% speedup through two key changes:

1. Module-level caching: Moves the expensive get_model_provider_metadata().keys() call from inside the validator to module load time, storing it in _VALID_PROVIDERS. This eliminates repeated calls to what appears to be a costly metadata retrieval function every time validation occurs.

2. Set-based membership testing: Converts the provider keys to a set instead of using a list, changing the membership test from O(n) to O(1) complexity. This is particularly beneficial when there are many supported providers.

The optimization is most effective for scenarios with:

• Repeated validations: Multiple provider validations benefit from the one-time metadata fetch
• Large provider lists: The set lookup becomes increasingly advantageous as the number of supported providers grows (as shown in the test_large_number_of_providers_invalid test case)
• High-frequency validation paths: Any code path that validates providers multiple times sees cumulative benefits

The cached approach trades a small amount of memory for significant runtime improvement, while maintaining identical validation behavior and error messages.

✅ Correctness verification report:

Test	Status
⚙️ Existing Unit Tests	🔘 None Found
🌀 Generated Regression Tests	✅ 10 Passed
⏪ Replay Tests	🔘 None Found
🔎 Concolic Coverage Tests	🔘 None Found
📊 Tests Coverage	100.0%

🌀 Generated Regression Tests and Runtime

import pytest
from langflow.api.v1.model_provider_credentials import \
    ModelProviderCredentialRequest


# --- Mock get_model_provider_metadata for testing purposes ---
# Since the original function is imported from another module, we'll define a mock version here
def get_model_provider_metadata():
    # Simulate a realistic set of providers
    return {
        "openai": {"description": "OpenAI GPT models"},
        "anthropic": {"description": "Anthropic Claude models"},
        "google": {"description": "Google PaLM models"},
        "azure": {"description": "Azure OpenAI Service"},
        "cohere": {"description": "Cohere models"},
        "huggingface": {"description": "HuggingFace Hub"},
        # Add more as needed for large scale tests
    }

# --- The function to test (as a standalone function for unit testing) ---
def validate_provider(v: str) -> str:
    """Validate that provider is in the valid list of supported providers."""
    valid_providers = list(get_model_provider_metadata().keys())
    if v not in valid_providers:
        msg = f"Invalid provider '{v}'. Must be one of: {', '.join(valid_providers)}"
        raise ValueError(msg)
    return v

# ------------------- UNIT TESTS -------------------

# --------- 1. Basic Test Cases ---------























#------------------------------------------------
import pytest
from langflow.api.v1.model_provider_credentials import \
    ModelProviderCredentialRequest

# --- Function to test (copied and slightly adapted for testability) ---
# We'll mock get_model_provider_metadata to control the valid providers in tests.

def get_model_provider_metadata():
    # This is a placeholder. It will be monkeypatched in the tests.
    return {}
from langflow.api.v1.model_provider_credentials import \
    ModelProviderCredentialRequest

# --- Unit tests ---

# Helper fixture to monkeypatch get_model_provider_metadata
@pytest.fixture
def patch_metadata(monkeypatch):
    def _patch(providers):
        def fake_metadata():
            return {p: {} for p in providers}
        monkeypatch.setattr(__name__ + ".get_model_provider_metadata", fake_metadata)
    return _patch

# ------------------- 1. BASIC TEST CASES -------------------

def test_valid_provider_single(patch_metadata):
    """Test with a single valid provider."""
    patch_metadata(['OpenAI'])
    codeflash_output = ModelProviderCredentialRequest.validate_provider('OpenAI')

def test_valid_provider_multiple(patch_metadata):
    """Test with multiple valid providers."""
    patch_metadata(['OpenAI', 'Anthropic', 'Google'])
    codeflash_output = ModelProviderCredentialRequest.validate_provider('Anthropic')
    codeflash_output = ModelProviderCredentialRequest.validate_provider('Google')

def test_invalid_provider_raises(patch_metadata):
    """Test with an invalid provider, should raise ValueError."""
    patch_metadata(['OpenAI', 'Anthropic'])
    with pytest.raises(ValueError) as excinfo:
        ModelProviderCredentialRequest.validate_provider('NotAProvider')

# ------------------- 2. EDGE TEST CASES -------------------

def test_empty_valid_providers_list(patch_metadata):
    """Test when no providers are valid (empty list)."""
    patch_metadata([])
    with pytest.raises(ValueError) as excinfo:
        ModelProviderCredentialRequest.validate_provider('Anything')

def test_empty_string_provider(patch_metadata):
    """Test when provider is an empty string."""
    patch_metadata(['OpenAI', 'Anthropic'])
    with pytest.raises(ValueError) as excinfo:
        ModelProviderCredentialRequest.validate_provider('')

def test_case_sensitivity(patch_metadata):
    """Test that provider matching is case-sensitive."""
    patch_metadata(['OpenAI'])
    with pytest.raises(ValueError):
        ModelProviderCredentialRequest.validate_provider('openai')  # Lowercase should not match

def test_whitespace_provider(patch_metadata):
    """Test provider string with leading/trailing whitespace."""
    patch_metadata(['OpenAI'])
    with pytest.raises(ValueError):
        ModelProviderCredentialRequest.validate_provider(' OpenAI ')
    # But if whitespace is in the valid list, it should pass
    patch_metadata([' OpenAI '])
    codeflash_output = ModelProviderCredentialRequest.validate_provider(' OpenAI ')







def test_large_number_of_providers_invalid(patch_metadata):
    """Test with a large number of valid providers, and an invalid input."""
    providers = [f'Provider{i}' for i in range(1000)]
    patch_metadata(providers)
    with pytest.raises(ValueError):
        ModelProviderCredentialRequest.validate_provider('NotAProvider')

To edit these changes git checkout codeflash/optimize-pr10351-2025-10-29T15.27.18 and push.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 32.82443% with 440 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (model-provider-keys-v2@d58de83). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...Component/components/modelInputComponent/index.tsx	0.00%	142 Missing ⚠️
...base/langflow/api/v1/model_provider_credentials.py	56.96%	68 Missing ⚠️
src/frontend/src/modals/apiKeyModal/index.tsx	0.00%	47 Missing ⚠️
src/lfx/src/lfx/base/models/unified_models.py	34.92%	41 Missing ⚠️
.../pages/ModelProvidersPage/components/Providers.tsx	0.00%	35 Missing ⚠️
src/backend/base/langflow/api/v1/models.py	51.66%	29 Missing ⚠️
...lers/API/queries/models/use-get-model-providers.ts	0.00%	17 Missing ⚠️
...ollers/API/queries/variables/use-get-categories.ts	32.00%	17 Missing ⚠️
...onents/inputComponent/components/popover/index.tsx	0.00%	13 Missing ⚠️
...backend/base/langflow/services/variable/service.py	76.47%	8 Missing ⚠️
... and 7 more

❌ Your patch status has failed because the patch coverage (32.82%) is below the target coverage (40.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@                    Coverage Diff                    @@
##             model-provider-keys-v2   #10441   +/-   ##
=========================================================
  Coverage                          ?   30.21%           
=========================================================
  Files                             ?     1329           
  Lines                             ?    60310           
  Branches                          ?     9021           
=========================================================
  Hits                              ?    18221           
  Misses                            ?    41258           
  Partials                          ?      831           

Flag	Coverage Δ
backend	51.02% <58.82%> (?)
lfx	39.52% <55.91%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/backend/base/langflow/api/router.py	100.00% <100.00%> (ø)
src/backend/base/langflow/inputs/inputs.py	0.00% <ø> (ø)
...angflow/services/database/models/variable/model.py	100.00% <100.00%> (ø)
...enderComponent/components/inputComponent/index.tsx	12.64% <ø> (ø)
...rComponent/components/strRenderComponent/index.tsx	0.00% <ø> (ø)
src/frontend/src/constants/constants.ts	95.40% <100.00%> (ø)
.../frontend/src/controllers/API/helpers/constants.ts	55.55% <ø> (ø)
...end/src/controllers/API/queries/variables/index.ts	100.00% <100.00%> (ø)
...PI/queries/variables/use-patch-global-variables.ts	45.45% <ø> (ø)
src/frontend/src/pages/SettingsPage/index.tsx	0.00% <ø> (ø)
... and 24 more

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[codeflash-ai]

This PR has been automatically closed because the original PR #10351 by HimavarshaVS was closed.