Skip to content

fix: Remove remote docling VLM component#10547

Merged
ogabrielluiz merged 7 commits into
mainfrom
fix-revert-vllm-docling
Nov 10, 2025
Merged

fix: Remove remote docling VLM component#10547
ogabrielluiz merged 7 commits into
mainfrom
fix-revert-vllm-docling

Conversation

@erichare
Copy link
Copy Markdown
Collaborator

@erichare erichare commented Nov 10, 2025

This pull request removes the DoclingRemoteVLMComponent from the codebase, due to ongoing issues with running Torch within the Langflow framework.

Component removal:

  • Deleted the entire implementation of DoclingRemoteVLMComponent, including its logic for provider selection, credential handling, dynamic model fetching, and VLM pipeline execution (src/lfx/src/lfx/components/docling/docling_remote_vlm.py).

Component loader updates:

  • Removed all references to DoclingRemoteVLMComponent from the __init__.py file, including import statements, dynamic import mapping, and the __all__ export list (src/lfx/src/lfx/components/docling/__init__.py).

Summary by CodeRabbit

  • Removed
    • Remote document conversion via cloud-hosted VLM services (Watsonx and OpenAI-compatible endpoints) is no longer available.

@erichare erichare requested a review from Cristhianzl November 10, 2025 16:53
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 10, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Removed the DoclingRemoteVLMComponent from the public API by deleting its implementation file and removing its lazy import exports from the module's initialization. This component previously facilitated remote VLM processing via Watsonx and OpenAI-compatible API endpoints with PDF document handling capabilities.

Changes

Cohort / File(s) Change Summary
Module exports
src/lfx/src/lfx/components/docling/__init__.py
Removed DoclingRemoteVLMComponent from public API: deleted TYPE_CHECKING import, removed entry from _dynamic_imports mapping, and removed from __all__ list. Component will no longer be lazily imported or accessible via module.
Component implementation
src/lfx/src/lfx/components/docling/docling_remote_vlm.py
Deleted entire component implementation file including class definition, metadata (display name, description, icon), supported file extensions, input/output configurations, model fetching logic, provider-specific VLM options builders (Watsonx and OpenAI-compatible), and file processing pipeline with DocumentConverter integration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Verify no remaining imports or references to DoclingRemoteVLMComponent elsewhere in the codebase
  • Confirm removal aligns with deprecation or feature discontinuation strategy
  • Check for any downstream dependencies or user-facing breaking changes related to the component removal

Possibly related PRs

Suggested labels

bug, lgtm

Suggested reviewers

  • mendonk
  • jordanrfrazier

Pre-merge checks and finishing touches

✅ Passed checks (7 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'fix: Remove remote docling VLM component' clearly and concisely summarizes the main change—removing the DoclingRemoteVLMComponent due to Torch compatibility issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Coverage For New Implementations ✅ Passed No test files exist for DoclingRemoteVLMComponent; removing deprecated functionality due to Torch integration issues requires no test updates.
Test Quality And Coverage ✅ Passed This PR removes existing code rather than implementing new functionality, making the Test Quality and Coverage check for new implementations inapplicable.
Test File Naming And Structure ✅ Passed PR properly removes DoclingRemoteVLMComponent without leaving orphaned test files. No test files reference the deleted component, confirming proper test structure patterns.
Excessive Mock Usage Warning ✅ Passed This PR removes the DoclingRemoteVLMComponent implementation. No test files are being modified or added, and no excessive mock usage patterns were found in any related tests.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the bug Something isn't working label Nov 10, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Nov 10, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 10, 2025

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 15%
14.67% (3955/26947) 7.45% (1533/20552) 9% (532/5906)

Unit Test Results

Tests Skipped Failures Errors Time
1588 0 💤 0 ❌ 0 🔥 19.125s ⏱️

@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Nov 10, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.40%. Comparing base (403b939) to head (d7cedfe).
⚠️ Report is 1 commits behind head on main.

❌ Your project status has failed because the head coverage (39.35%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (403b939) and HEAD (d7cedfe). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (403b939) HEAD (d7cedfe)
frontend 2 1
backend 10 5
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10547      +/-   ##
==========================================
- Coverage   38.90%   31.40%   -7.50%     
==========================================
  Files        1477     1325     -152     
  Lines       85270    59995   -25275     
  Branches    10240     8983    -1257     
==========================================
- Hits        33175    18843   -14332     
+ Misses      51048    40245   -10803     
+ Partials     1047      907     -140     
Flag Coverage Δ
backend 50.93% <ø> (-5.93%) ⬇️
frontend 13.57% <ø> (-0.78%) ⬇️
lfx 39.35% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 372 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erichare erichare requested a review from Adam-Aghili November 10, 2025 17:04
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Nov 10, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Nov 10, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Nov 10, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Nov 10, 2025
@erichare erichare enabled auto-merge November 10, 2025 17:39
Copy link
Copy Markdown
Collaborator

@Adam-Aghili Adam-Aghili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions Bot added the lgtm This PR has been approved by a maintainer label Nov 10, 2025
@ogabrielluiz ogabrielluiz merged commit bfbaeab into main Nov 10, 2025
126 of 129 checks passed
@ogabrielluiz ogabrielluiz deleted the fix-revert-vllm-docling branch November 10, 2025 17:56
korenLazar pushed a commit to kiran-kate/langflow that referenced this pull request Nov 13, 2025
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Adam Aghili <Adam.Aghili@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants