fix: refactor Ollama model fetching to use async and filter capabilities#10550
Merged
Conversation
Replaces synchronous requests for Ollama model fetching with asynchronous httpx calls and adds filtering to only include models with 'completion' capability. Updates the LanguageModelComponent to support async validation and fetching of Ollama models, improving reliability and accuracy of available model options.
Introduces several Notion-related components for Langflow, including AddContentToPage, NotionDatabaseProperties, NotionListPages, NotionPageContent, NotionPageCreator, NotionPageUpdate, and NotionSearch. Updates the component index to register these new tools, enabling Notion API interactions such as page creation, content retrieval, database property listing, and more.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Frontend Unit Test Coverage ReportCoverage Summary
Unit Test Results
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fix/ollama_embeddings #10550 +/- ##
========================================================
Coverage ? 39.35%
========================================================
Files ? 1476
Lines ? 82224
Branches ? 8991
========================================================
Hits ? 32359
Misses ? 48959
Partials ? 906
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ogabrielluiz
requested changes
Nov 10, 2025
Comment on lines
+112
to
+115
| async with httpx.AsyncClient() as client: | ||
| # Fetch available models | ||
| tags_response = await client.get(url=tags_url) | ||
| tags_response.raise_for_status() |
Contributor
There was a problem hiding this comment.
it seems the AsyncClient is only used on the first line
Collaborator
Author
There was a problem hiding this comment.
This is tricky when I moved it out of context
Contributor
There was a problem hiding this comment.
get the .json() call in the context and it should work.
Refactored the LanguageModelComponent code in Basic Prompt Chaining.json to improve formatting and readability. No functional changes were made; only code style and structure were updated.
Collaborator
Author
|
@ogabrielluiz I have usedd a bse function in both embedding and langauge model component |
Moves Ollama model fetching and URL validation logic from the LanguageModelComponent class to shared utility functions in model_utils. Updates references in starter project JSONs to use the new utility functions for improved code reuse and maintainability.
…ollama-models-loading
Adds logic to skip processing text content when message state is 'complete' in OpenAI response streaming, ensuring only content_blocks are processed for tool calls. Updates LCModelComponent to set state to 'partial' during streaming and only update the database with 'complete' state, without sending a new message event, as the frontend already has all streamed content.
lucaseduoli
force-pushed
the
fix-ollama-models-loading
branch
from
882e26c to
0c2c01e
Compare
lucaseduoli
force-pushed
the
fix-ollama-models-loading
branch
from
868fb78 to
895284f
Compare
lucaseduoli
force-pushed
the
fix-ollama-models-loading
branch
from
2660ccd to
dd07a95
Compare
lucaseduoli
changed the title
kerinin
pushed a commit
that referenced
this pull request
Nov 11, 2025
…API come with type of last complete message (#10558) (I'm going to force-push to get this in while the nightly is broken - this is needed for QA ASAP) * Changed embedding model to show api base when switching embedding models * fix: refactor Ollama model fetching to use async and filter capabilities (#10550) * Refactor Ollama model fetching to use async and filter capabilities Replaces synchronous requests for Ollama model fetching with asynchronous httpx calls and adds filtering to only include models with 'completion' capability. Updates the LanguageModelComponent to support async validation and fetching of Ollama models, improving reliability and accuracy of available model options. * Update language_model.py * Add Notion integration components Introduces several Notion-related components for Langflow, including AddContentToPage, NotionDatabaseProperties, NotionListPages, NotionPageContent, NotionPageCreator, NotionPageUpdate, and NotionSearch. Updates the component index to register these new tools, enabling Notion API interactions such as page creation, content retrieval, database property listing, and more. * [autofix.ci] apply automated fixes * [autofix.ci] apply automated fixes (attempt 2/3) * [autofix.ci] apply automated fixes (attempt 3/3) * Update LanguageModelComponent code in starter projects Refactored the LanguageModelComponent code in Basic Prompt Chaining.json to improve formatting and readability. No functional changes were made; only code style and structure were updated. * Refactor Ollama model fetching logic Moves Ollama model fetching and URL validation logic from the LanguageModelComponent class to shared utility functions in model_utils. Updates references in starter project JSONs to use the new utility functions for improved code reuse and maintainability. * Update component_index.json * Update Nvidia Remix.json * Handle message state for streaming responses Adds logic to skip processing text content when message state is 'complete' in OpenAI response streaming, ensuring only content_blocks are processed for tool calls. Updates LCModelComponent to set state to 'partial' during streaming and only update the database with 'complete' state, without sending a new message event, as the frontend already has all streamed content. * fixed test * Changed embedding model component * removed default values * fixed ruff * fixed starter projects --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Lucas Oliveira <lucas.edu.oli@hotmail.com> * fixed backend test * fixed llm test * fixed update build config ollama test * fixed test embedding model component --------- Co-authored-by: Edwin Jose <edwin.jose@datastax.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces synchronous requests for Ollama model fetching with asynchronous httpx calls and adds filtering to only include models with 'completion' capability. Updates the LanguageModelComponent to support async validation and fetching of Ollama models, improving reliability and accuracy of available model options.