Skip to content

ci: require main image built before backend/frontend images#10561

Merged
jordanrfrazier merged 2 commits into
mainfrom
fix-docker-build-backend
Nov 11, 2025
Merged

ci: require main image built before backend/frontend images#10561
jordanrfrazier merged 2 commits into
mainfrom
fix-docker-build-backend

Conversation

@jordanrfrazier
Copy link
Copy Markdown
Collaborator

@jordanrfrazier jordanrfrazier commented Nov 11, 2025

Fixes issue: https://github.com/langflow-ai/langflow/actions/runs/19172919177/job/54811540811

Summary by CodeRabbit

  • Chores
    • Updated release workflow orchestration to optimize build sequencing.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 11, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Modified workflow dependency wiring in the release pipeline. Changed three Docker build job definitions to depend on call_docker_build_main instead of the ci job, altering the orchestration sequence for Docker-based release builds.

Changes

Cohort / File(s) Change Summary
Release Workflow Job Dependencies
​.github/workflows/release.yml
Updated call_docker_build_main_backend, call_docker_build_main_frontend, and call_docker_build_main job needs declarations from [ci] to [call_docker_build_main], restructuring job dependencies in the release pipeline

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

  • Single file with declarative job dependency changes
  • Changes are isolated to needs field updates in three jobs
  • Verify the new dependency chain is acyclic and doesn't introduce circular references (note: call_docker_build_main depending on itself may warrant clarification)

Possibly related PRs

  • #9988: Modifies Docker build call job wiring in release.yml
  • #9205: Changes job dependency declarations in release.yml including call_docker_build_main

Suggested labels

bug, size:S

Pre-merge checks and finishing touches

✅ Passed checks (7 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: requiring the main Docker image to be built before backend/frontend images in the CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Coverage For New Implementations ✅ Passed PR is primarily a GitHub Actions workflow orchestration fix with minimal code changes (logging import); no new testable functionality requiring unit tests.
Test Quality And Coverage ✅ Passed This PR modifies only GitHub Actions workflow configuration (.github/workflows/release.yml) for CI/CD orchestration, not functional code or features requiring test evaluation.
Test File Naming And Structure ✅ Passed The PR only modifies .github/workflows/release.yml, a GitHub Actions workflow file, with no changes to test files or test structure.
Excessive Mock Usage Warning ✅ Passed The pull request modifies only GitHub Actions workflow configuration, not test files. The excessive mock usage check is inapplicable to non-test code.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.22%. Comparing base (91d73e7) to head (d91f270).
⚠️ Report is 4 commits behind head on main.

❌ Your project status has failed because the head coverage (39.35%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10561      +/-   ##
==========================================
+ Coverage   31.47%   37.22%   +5.74%     
==========================================
  Files        1328     1423      +95     
  Lines       60091    78049   +17958     
  Branches     8986     8927      -59     
==========================================
+ Hits        18912    29050   +10138     
- Misses      40272    48102    +7830     
+ Partials      907      897      -10     
Flag Coverage Δ
backend 55.92% <ø> (+4.77%) ⬆️
frontend 10.13% <ø> (-3.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 479 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@Adam-Aghili Adam-Aghili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as dry run passes! Thank you for solving this @jordanrfrazier

dry run: https://github.com/langflow-ai/langflow/actions/runs/19270588358

@github-actions github-actions Bot added the lgtm This PR has been approved by a maintainer label Nov 11, 2025
@jordanrfrazier jordanrfrazier added this pull request to the merge queue Nov 11, 2025
Merged via the queue into main with commit e6539e1 Nov 11, 2025
254 of 256 checks passed
@jordanrfrazier jordanrfrazier deleted the fix-docker-build-backend branch November 11, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants