Skip to content

chore: remove component: dataframe to toolset#10643

Closed
edwinjosechittilappilly wants to merge 17 commits into
release-1.7.0from
deprecate-components-main
Closed

chore: remove component: dataframe to toolset#10643
edwinjosechittilappilly wants to merge 17 commits into
release-1.7.0from
deprecate-components-main

Conversation

@edwinjosechittilappilly
Copy link
Copy Markdown
Collaborator

@edwinjosechittilappilly edwinjosechittilappilly commented Nov 18, 2025

This pull request removes the unit tests for the DataFrameToToolsetComponent from the codebase. The test file test_dataframe_toolset.py is deleted, which means automated testing for this component is no longer present. No changes were made to the implementation of the component itself.

Added the 'legacy = True' attribute to DataFrameToToolsetComponent and DynamicCreateDataComponent to indicate their legacy status.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 18, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Two component classes in the processing module were updated to include a new public legacy = True attribute: DataFrameToToolsetComponent and DynamicCreateDataComponent. No logic or behavioral changes were introduced.

Changes

Cohort / File(s) Summary
Component Legacy Attributes
src/lfx/src/lfx/components/processing/dataframe_to_toolset.py, src/lfx/src/lfx/components/processing/dynamic_create_data.py
Added public class attribute legacy = True to DataFrameToToolsetComponent and DynamicCreateDataComponent to signal legacy behavior status.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

This change involves adding a simple class attribute to two files with no logic modifications or behavioral changes.

Suggested labels

size:XS, lgtm

Suggested reviewers

  • Yukiyukiyeah
  • erichare

Pre-merge checks and finishing touches

❌ Failed checks (1 error, 4 warnings)
Check name Status Explanation Resolution
Test Coverage For New Implementations ❌ Error PR adds legacy attribute to two components without corresponding test coverage verifying the attribute is set correctly or that components remain functional. Add test files verifying the legacy attribute is correctly set on both components and that they remain functional after being marked as legacy.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Test Quality And Coverage ⚠️ Warning PR adds legacy attribute to components but lacks tests verifying this attribute, inconsistent with established codebase patterns. Add test_component_legacy_status methods to test files verifying legacy=True for both modified components.
Test File Naming And Structure ⚠️ Warning Pull request adds legacy = True attribute to components but existing tests lack assertions verifying this new attribute. Add assert component.legacy is True assertions to test_component_properties methods in both test files to verify the legacy attribute.
Title check ⚠️ Warning The PR title states 'remove component: dataframe to toolset', but the actual changes add a legacy=True attribute to mark components as legacy rather than removing them. Update the title to accurately reflect the changes, such as 'chore: Mark processing components as legacy' to match the actual modifications and PR objectives.
✅ Passed checks (2 passed)
Check name Status Explanation
Excessive Mock Usage Warning ✅ Passed Test files for modified components contain no mocks and use real instances to verify actual behavior, demonstrating excellent test design practices.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 18, 2025

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 15%
15.29% (4188/27381) 8.49% (1778/20935) 9.6% (579/6031)

Unit Test Results

Tests Skipped Failures Errors Time
1638 0 💤 0 ❌ 0 🔥 21.422s ⏱️

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-1.7.0@4df89f1). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...rc/lfx/src/lfx/base/embeddings/embeddings_class.py 0.00% 21 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-1.7.0   #10643   +/-   ##
================================================
  Coverage                 ?   32.52%           
================================================
  Files                    ?     1367           
  Lines                    ?    63359           
  Branches                 ?     9368           
================================================
  Hits                     ?    20608           
  Misses                   ?    41717           
  Partials                 ?     1034           
Flag Coverage Δ
backend 51.62% <ø> (?)
lfx 39.98% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/lfx/src/lfx/base/embeddings/embeddings_class.py 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Deleted the DataFrameToToolsetComponent implementation and its associated unit tests. This removes support for converting DataFrame rows into toolset actions, likely as part of a refactor or deprecation.
@edwinjosechittilappilly edwinjosechittilappilly changed the title chore: Mark processing components as legacy chore: remove component: dataframe to toolset Nov 25, 2025
@edwinjosechittilappilly edwinjosechittilappilly marked this pull request as ready for review November 25, 2025 00:32
HzaRashid and others added 5 commits November 25, 2025 18:45
* feat: optimize dropdown filtering and output resolution

misc: remove commented out code

feat: add refresh button and sort flows by updated_at date from most to least recent

ruff (flow.py imports)

improve fn contracts in runflow and improve flow id retrieval logic based on graph exec context

add dynamic outputs and optimize db lookups

add flow cache and db query for getting a single flow by id or name

cache run outputs and add refresh context to build config

misc

misc

use ids for flow retrieval

misc

fix missing flow_id bug

add unit and integration tests

add input field flag to persist hidden fields at runtime

move unit tests and change input and output display names

chore: update component index

fix: fix tool mode when flow has multiple inputs by dynamically creating resolvers

chore: update component index

ruff (run_flow and tests)

add resolvers to outputs map for non tool mode runtime

fix tests (current flow excluded in db fetch)

mypy (helpers/flow.py)

chore: update component index

remove unused code and clean up comments

fix: persist user messages in chat-based flows via session injection

chore: update component index

empty string fallback for sessionid in chat.py

chore: update component index

chore: update component index

cache invalidation with timestamps

misc

add cache invalidation

chore: update component index

chore: update comp idx

ruff (run_flow.py)

change session_id input type to MessageTextInput

chore: update component index

chore: update component index

chore: update component index

chore: update component index

sync starter projects with main

chore: update component index

chore: update component index

chore: update component index

remove dead code + impl coderabbit suggestions

chore: update component index

chore: update component index

clear options metadata before updating

chore: update component index

sync starter projects with main

sync starter projects with main

default param val (list flows)

* chore: update component index

* add integration tests

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

---------

Co-authored-by: Cristhian Zanforlin <criszl@192.168.15.88>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
* Add OpenSearch multimodal multi-embedding component

Introduces OpenSearchVectorStoreComponentMultimodalMultiEmbedding, supporting multi-model hybrid semantic and keyword search with dynamic vector fields, parallel embedding generation, advanced filtering, and flexible authentication. Enables ingestion and search across multiple embedding models in OpenSearch, with robust index management and UI configuration handling.

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes

* Add EmbeddingsWithModels and sync model fetching

Introduces EmbeddingsWithModels class for wrapping embeddings and available models. Updates EmbeddingModelComponent to provide available model lists for OpenAI, Ollama, and IBM watsonx.ai providers, including synchronous Ollama model fetching using httpx. Updates starter project and component index metadata to reflect new dependencies and code changes.

* Refactor embedding model component to use async Ollama model fetch

Updated the EmbeddingModelComponent to fetch Ollama models asynchronously using await get_ollama_models instead of a synchronous httpx call. Removed httpx from dependencies in Nvidia Remix starter project and updated related metadata. This change improves consistency and reliability when fetching available models for the Ollama provider.

* update to embeddings to support multiple models

* Add Notion integration components

Added several Notion-related components to the component index, including AddContentToPage, NotionDatabaseProperties, NotionListPages, NotionPageContent, NotionPageCreator, NotionPageUpdate, and NotionSearch. These components enable interaction with Notion databases and pages, such as querying, updating, creating, and retrieving content.

* Add tests for multi-model embeddings and OpenSearch

Added unit tests for EmbeddingsWithModels class and OpenSearchVectorStoreComponentMultimodalMultiEmbedding, including model normalization, authentication modes, and integration scenarios. Updated embedding model component tests to support async build_embeddings and verify multi-model support. Created necessary test package __init__.py files.

* Update component_index.json

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* Fix session_id handling in ChatInput and ChatOutput

Updated ChatInput and ChatOutput components in starter project JSONs to use the session_id from the graph if not provided, ensuring consistent session management. This change improves message storage and retrieval logic for chat flows.

* Update test_opensearch_multimodal.py

* [autofix.ci] apply automated fixes

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
@carlosrcoelho carlosrcoelho added this pull request to the merge queue Nov 26, 2025
github-merge-queue Bot pushed a commit that referenced this pull request Nov 26, 2025
* Mark processing components as legacy

Added the 'legacy = True' attribute to DataFrameToToolsetComponent and DynamicCreateDataComponent to indicate their legacy status.

* [autofix.ci] apply automated fixes

* [autofix.ci] apply automated fixes (attempt 2/3)

* Remove DataFrame to Toolset component and tests

Deleted the DataFrameToToolsetComponent implementation and its associated unit tests. This removes support for converting DataFrame rows into toolset actions, likely as part of a refactor or deprecation.

* Update dynamic_create_data.py

* Update component_index.json

* Update component_index.json

* Update __init__.py

* Update component_index.json

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 26, 2025
@edwinjosechittilappilly
Copy link
Copy Markdown
Collaborator Author

@carlosrcoelho @Cristhianzl can you take a look into this PR and merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants