Skip to content

fix: rename LLM router to LLM selector#10650

Merged
keval718 merged 23 commits into
mainfrom
fix-rename-LLM-router-to-LLM-selector
Nov 21, 2025
Merged

fix: rename LLM router to LLM selector#10650
keval718 merged 23 commits into
mainfrom
fix-rename-LLM-router-to-LLM-selector

Conversation

@keval718
Copy link
Copy Markdown
Collaborator

@keval718 keval718 commented Nov 18, 2025

-- Rename LLM router to LLM Selector

image

Summary by CodeRabbit

  • Style
    • Updated the display name of the LLM Selector component for improved clarity and consistency.

@keval718 keval718 self-assigned this Nov 18, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 18, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The display_name attribute of the LLMRouterComponent is renamed from "LLM Router" to "LLM Selector" in a single file. No functional or logic changes are introduced.

Changes

Cohort / File(s) Summary
Display name update
src/lfx/src/lfx/components/llm_operations/llm_router.py
Changed display_name from "LLM Router" to "LLM Selector"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)
Check name Status Explanation Resolution
Test Coverage For New Implementations ❌ Error PR modifies display_name attribute in llm_router.py but includes no corresponding test files to verify the change. Add test file verifying the display_name attribute value or confirm display_name changes do not require testing per project standards.
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: renaming the LLM Router component's display name to LLM Selector, which matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Test Quality And Coverage ✅ Passed Pull request contains only a cosmetic rename of UI display label from 'LLM Router' to 'LLM Selector' with no functional modifications.
Test File Naming And Structure ✅ Passed PR only modifies a display name string in LLMRouterComponent with no functional changes and no test files were added, modified, or deleted.
Excessive Mock Usage Warning ✅ Passed This custom check for excessive mock usage is not applicable to this pull request. The PR contains only a single, trivial change: renaming the display_name attribute of the LLMRouterComponent from "LLM Router" to "LLM Selector". No test files were modified, no new tests were added, and no mock usage was introduced or altered by this change. The PR is purely a cosmetic rename with no impact on test design or mock usage patterns.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the bug Something isn't working label Nov 18, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 18, 2025

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 15%
14.68% (3985/27139) 7.56% (1560/20608) 8.94% (535/5984)

Unit Test Results

Tests Skipped Failures Errors Time
1630 0 💤 0 ❌ 0 🔥 18.989s ⏱️

@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Nov 18, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.63%. Comparing base (63ab3ac) to head (4d43c75).
⚠️ Report is 1 commits behind head on main.

❌ Your project status has failed because the head coverage (38.95%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10650      +/-   ##
==========================================
- Coverage   31.63%   31.63%   -0.01%     
==========================================
  Files        1350     1350              
  Lines       61154    61154              
  Branches     9142     9142              
==========================================
- Hits        19348    19347       -1     
  Misses      40890    40890              
- Partials      916      917       +1     
Flag Coverage Δ
backend 51.82% <ø> (ø)
frontend 13.59% <ø> (ø)
lfx 38.95% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@Adam-Aghili Adam-Aghili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this require a doc change?
https://docs.langflow.org/components-processing#llm-router

It might be worth refactoring the component, file and path names.

llm_router.py -> llm_selector.py

@@ -15,7 +15,7 @@


class LLMRouterComponent(Component):
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class LLMRouterComponent(Component):
class LLMSelectorComponent(Component):

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks!

@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Nov 19, 2025
@keval718 keval718 force-pushed the fix-rename-LLM-router-to-LLM-selector branch from 77ee8b7 to ae6ae34 Compare November 19, 2025 20:11
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Nov 19, 2025
@keval718 keval718 force-pushed the fix-rename-LLM-router-to-LLM-selector branch from 673e75e to d62e5a0 Compare November 19, 2025 20:14
@keval718 keval718 enabled auto-merge November 19, 2025 20:15
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Nov 19, 2025
@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Nov 21, 2025
@keval718 keval718 added this pull request to the merge queue Nov 21, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 21, 2025
@keval718 keval718 added this pull request to the merge queue Nov 21, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants