test: Improve output inspection button selector reliability#10757
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes modify two test files in the frontend E2E test suite. One test updates its interaction pattern to include a readiness check before engaging with output inspection controls. The other test file undergoes formatting and indentation adjustments without functional modifications. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (40.04%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #10757 +/- ##
==========================================
- Coverage 32.40% 32.38% -0.03%
==========================================
Files 1368 1368
Lines 63412 63412
Branches 9373 9373
==========================================
- Hits 20551 20537 -14
- Misses 41829 41843 +14
Partials 1032 1032
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…gflow into cz/improve-run-flow-test
This pull request updates the test logic for interacting with the output inspection button in the
run-flow.spec.tstest suite. The main change improves the reliability of the test by waiting for the output inspection button to appear using a partial match on its data-testid, rather than clicking a static icon.Test reliability improvement:
data-testid, instead of directly clicking theicon-TextSearchIconelement. This makes the test more robust against UI changes.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.